From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45347) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cejEy-0002u2-5y for qemu-devel@nongnu.org; Fri, 17 Feb 2017 09:10:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cejEu-0002kW-Bl for qemu-devel@nongnu.org; Fri, 17 Feb 2017 09:10:28 -0500 Date: Fri, 17 Feb 2017 22:10:15 +0800 From: Fam Zheng Message-ID: <20170217141015.GC15819@lemon.lan> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v2 2/7] iscsi: Handle -iscsi user/password in bdrv_parse_filename() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody Cc: qemu-devel@nongnu.org, kwolf@redhat.com, pbonzini@redhat.com, qemu-block@nongnu.org On Wed, 01/25 12:42, Jeff Cody wrote: > From: Kevin Wolf > > This splits the logic in the old parse_chap() function into a part that > parses the -iscsi options into the new driver-specific options, and > another part that actually applies those options (called apply_chap() > now). > > Note that this means that username and password specified with -iscsi > only take effect when a URL is provided. This is intentional, -iscsi is > a legacy interface only supported for compatibility, new users should > use the proper driver-specific options. > > Signed-off-by: Kevin Wolf > Signed-off-by: Jeff Cody Reviewed-by: Fam Zheng