From: Kevin Wolf <kwolf@redhat.com>
To: Nir Soffer <nirsof@gmail.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/3] qemu-img: Add tests for raw image preallocation
Date: Fri, 17 Feb 2017 15:27:27 +0100 [thread overview]
Message-ID: <20170217142727.GK5338@noname.redhat.com> (raw)
In-Reply-To: <CAMr-obu0RPWyTcJHGA5b_Hs3L3usOvFNJ0N+runD4ZyMMvgWFg@mail.gmail.com>
Am 17.02.2017 um 15:20 hat Nir Soffer geschrieben:
> On Fri, Feb 17, 2017 at 11:14 AM, Kevin Wolf <kwolf@redhat.com> wrote:
> > Am 17.02.2017 um 01:51 hat Nir Soffer geschrieben:
> >> Add tests for creating raw image with and without the preallocation
> >> option.
> >>
> >> Signed-off-by: Nir Soffer <nirsof@gmail.com>
> >
> > Looks good, but 175 is already (multiply) taken. Not making this a
> > blocker, but I just want to remind everyone to check the mailing list
> > for pending patches which add new tests before using a new number in
> > order to avoid unnecessary rebases for everyone. In general, it's as
> > easy as searching for the string "175.out" in the mailbox.
> >
> > The next free one seems to be 177 currently.
>
> Thanks, will change to 177 in the next version.
If there needs to be a next version for other reasons. Otherwise it's
not important enough to respin, it just means that someone else will
have to rebase.
> For next patches, what do you mean by "pending"? patches sent
> to the block mailing list?
Yes, that's what I'm looking for when I add a new test case myself. It's
just an easy way to avoid stepping on each others toes.
Kevin
next prev parent reply other threads:[~2017-02-17 14:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-17 0:51 [Qemu-devel] [PATCH 0/3] qemu-img raw preallocation Nir Soffer
2017-02-17 0:51 ` [Qemu-devel] [PATCH 1/3] qemu-img: Add tests for raw image preallocation Nir Soffer
2017-02-17 9:14 ` Kevin Wolf
2017-02-17 14:20 ` Nir Soffer
2017-02-17 14:27 ` Kevin Wolf [this message]
2017-02-17 0:51 ` [Qemu-devel] [PATCH 2/3] qemu-img: Truncate before full preallocation Nir Soffer
2017-02-17 0:51 ` [Qemu-devel] [PATCH 3/3] qemu-img: Improve documentation for PREALLOC_MODE_FALLOC Nir Soffer
2017-02-22 12:31 ` [Qemu-devel] [PATCH 0/3] qemu-img raw preallocation Kevin Wolf
2017-02-22 13:52 ` Nir Soffer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170217142727.GK5338@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=nirsof@gmail.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).