From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43353) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ceoZG-0001DZ-Nm for qemu-devel@nongnu.org; Fri, 17 Feb 2017 14:51:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ceoZF-0003IJ-R0 for qemu-devel@nongnu.org; Fri, 17 Feb 2017 14:51:46 -0500 Date: Fri, 17 Feb 2017 19:51:33 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20170217195133.GB20911@work-vm> References: <1486979689-230770-1-git-send-email-vsementsov@virtuozzo.com> <1486979689-230770-16-git-send-email-vsementsov@virtuozzo.com> <20170216134830.GB28784@lemon.lan> <20170217122141.GD3468@lemon.lan> <4fbb78a1-a486-3031-1666-6f586a5d4ab9@virtuozzo.com> <20170217140537.GA15819@lemon.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170217140537.GA15819@lemon.lan> Subject: Re: [Qemu-devel] [PATCH 15/17] iotests: add default node-name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org, qemu-devel@nongnu.org, kwolf@redhat.com, peter.maydell@linaro.org, lirans@il.ibm.com, quintela@redhat.com, jsnow@redhat.com, armbru@redhat.com, mreitz@redhat.com, stefanha@redhat.com, den@openvz.org, pbonzini@redhat.com, jdenemar@redhat.com * Fam Zheng (famz@redhat.com) wrote: > On Fri, 02/17 16:36, Vladimir Sementsov-Ogievskiy wrote: > > 17.02.2017 15:21, Fam Zheng wrote: > > > On Fri, 02/17 13:20, Vladimir Sementsov-Ogievskiy wrote: > > > > 16.02.2017 16:48, Fam Zheng wrote: > > > > > On Mon, 02/13 12:54, Vladimir Sementsov-Ogievskiy wrote: > > > > > > When testing migration, auto-generated by qemu node-names differs in > > > > > > source and destination qemu and migration fails. After this patch, > > > > > > auto-generated by iotest nodenames will be the same. > > > > > What should be done in libvirt to make sure the node-names are matching > > > > > correctly at both sides? > > > > Hmm, just set node names appropriately? > > > But I think the problem is that node names are not configurable from libvirt > > > today, and then the migration will fail. Should the device name take precedence > > > in the code, to make it easier? > > > > libvirt can use same parameters as I in this patch.. > > If I'm not mistaken, libvirt can be patched to explicitly set the same node > names in the QEMU command line, but that is some extra work to do there. My > point is if device names are used during migration, when available, this patch > and the libvirt change is not necessary. Always best to check with libvirt guys to see what makes sense for them; ccing in jdenemar. Dave > Fam -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK