From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40397) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ceppU-0000x2-UU for qemu-devel@nongnu.org; Fri, 17 Feb 2017 16:12:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ceppT-00071M-MV for qemu-devel@nongnu.org; Fri, 17 Feb 2017 16:12:36 -0500 Date: Fri, 17 Feb 2017 16:12:30 -0500 From: Jeff Cody Message-ID: <20170217211230.GH19045@localhost.localdomain> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v2 0/7] iscsi: Add blockdev-add support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, kwolf@redhat.com, berrange@redhat.com, pbonzini@redhat.com On Wed, Jan 25, 2017 at 12:42:01PM -0500, Jeff Cody wrote: > This adds blockdev-add support to the iscsi block driver. > > Picked this series up from Kevin. I've tested it on my local iscsi setup. > > There are only a few minor changes: > > * In patch 2, fixed the segfault pointed out by Daniel > * In patch 6, placed the ':' after the command header as now required > * New patch 7, to fix some out of date documentation in the qapi schema > > > Jeff Cody (1): > QAPI: Fix blockdev-add example documentation > > Kevin Wolf (6): > iscsi: Split URL into individual options > iscsi: Handle -iscsi user/password in bdrv_parse_filename() > iscsi: Add initiator-name option > iscsi: Add header-digest option > iscsi: Add timeout option > iscsi: Add blockdev-add support > > block/iscsi.c | 349 +++++++++++++++++++++++++++++++-------------------- > qapi/block-core.json | 92 +++++++++++--- > 2 files changed, 288 insertions(+), 153 deletions(-) > > -- > 2.9.3 > Fixed up the formatting issues pointed out by Fam & patchew, and applied to my block branch: git://github.com/codyprime/qemu-kvm-jtc.git block -Jeff