From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: pavel.dovgaluk@ispras.ru, peter.maydell@linaro.org
Subject: [Qemu-devel] [PATCH 3/3] cpu-exec: remove unnecessary check of cpu->exit_request
Date: Tue, 21 Feb 2017 13:46:38 +0100 [thread overview]
Message-ID: <20170221124638.19573-4-pbonzini@redhat.com> (raw)
In-Reply-To: <20170221124638.19573-1-pbonzini@redhat.com>
The cpu->exit_request check in cpu_loop_exec_tb is unnecessary,
because cpu->tcg_exit_req is always set after cpu->exit_request.
So let the TB exit and we will pick up the exit request later
in cpu_handle_interrupt.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
cpu-exec.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/cpu-exec.c b/cpu-exec.c
index bf126dd..db1de5a 100644
--- a/cpu-exec.c
+++ b/cpu-exec.c
@@ -535,10 +535,6 @@ static inline void cpu_loop_exec_tb(CPUState *cpu, TranslationBlock *tb,
uintptr_t ret;
int32_t insns_left;
- if (unlikely(atomic_read(&cpu->exit_request))) {
- return;
- }
-
trace_exec_tb(tb, tb->pc);
ret = cpu_tb_exec(cpu, tb);
tb = (TranslationBlock *)(ret & ~TB_EXIT_MASK);
--
2.9.3
next prev parent reply other threads:[~2017-02-21 12:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-21 12:46 [Qemu-devel] [PATCH 0/3] cpu-exec: icount and exit request cleanups Paolo Bonzini
2017-02-21 12:46 ` [Qemu-devel] [PATCH 1/3] cpu-exec: unify icount_decr and tcg_exit_req Paolo Bonzini
2017-02-21 12:46 ` [Qemu-devel] [PATCH 2/3] replay: check icount in cpu exec loop Paolo Bonzini
2017-02-21 12:46 ` Paolo Bonzini [this message]
2017-02-21 14:25 ` [Qemu-devel] [PATCH 0/3] cpu-exec: icount and exit request cleanups no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170221124638.19573-4-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=pavel.dovgaluk@ispras.ru \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).