From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Ziyue Yang <skiver.cloud.yzy@gmail.com>,
qemu-devel@nongnu.org, Ziyue Yang <yzylivezh@hotmail.com>,
Pavel Butsykin <pbutsykin@virtuozzo.com>
Subject: Re: [Qemu-devel] [PATCH 0/2] fix segfaults caused by accessing CPU in empty machine
Date: Tue, 21 Feb 2017 19:42:06 +0000 [thread overview]
Message-ID: <20170221194206.GK2377@work-vm> (raw)
In-Reply-To: <5a03f6f2-f867-8dfe-28bb-6f481782f6af@redhat.com>
* Thomas Huth (thuth@redhat.com) wrote:
> On 17.02.2017 09:27, Ziyue Yang wrote:
> > From: Ziyue Yang <yzylivezh@hotmail.com>
> >
> > Many QEMU monitor commands, like "info lapic", "info tlb" and so on
> > use mon_get_cpu or related wrappers to access CPU info without checking
> > whether the CPU exists.
> > This patch series fix the "info lapic" case, and is the base of the incoming
> > patch series aiming to eliminate segfaults caused by other QEMU commands
> > trying to access CPU that doesn't exist.
>
> Hi,
>
> FYI, I've posted a patch for all of these monitor commands that crash
> without CPU already last month:
>
> https://lists.gnu.org/archive/html/qemu-devel/2017-01/msg02602.html
I've just sent that in my HMP pull:
https://lists.nongnu.org/archive/html/qemu-devel/2017-02/msg04939.html
Ziyue Yang: Perhaps it's best to compare with the things in that
pull and check to see if you have any items that were not in that pull.
Dave
> Thomas
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
prev parent reply other threads:[~2017-02-21 19:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-17 8:27 [Qemu-devel] [PATCH 0/2] fix segfaults caused by accessing CPU in empty machine Ziyue Yang
2017-02-17 8:27 ` [Qemu-devel] [PATCH 1/2] monitor.c: make mon_get_cpu return NULL when there is no CPU Ziyue Yang
2017-02-19 3:55 ` Philippe Mathieu-Daudé
2017-02-20 6:09 ` Thomas Huth
2017-02-20 9:33 ` Yang Ziyue
2017-02-17 8:27 ` [Qemu-devel] [PATCH 2/2] target/i386/monitor.c: check return value of mon_get_cpu before using it Ziyue Yang
2017-02-19 3:56 ` Philippe Mathieu-Daudé
2017-02-20 6:07 ` [Qemu-devel] [PATCH 0/2] fix segfaults caused by accessing CPU in empty machine Thomas Huth
2017-02-21 19:42 ` Dr. David Alan Gilbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170221194206.GK2377@work-vm \
--to=dgilbert@redhat.com \
--cc=pbutsykin@virtuozzo.com \
--cc=qemu-devel@nongnu.org \
--cc=skiver.cloud.yzy@gmail.com \
--cc=thuth@redhat.com \
--cc=yzylivezh@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).