From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: eblake@redhat.com, marcandre.lureau@redhat.com
Subject: [Qemu-devel] [PATCH v2 0/3] simplify struct QOM properties and use the result for GUEST_PANICKED
Date: Wed, 22 Feb 2017 19:04:20 +0100 [thread overview]
Message-ID: <20170222180423.26571-1-pbonzini@redhat.com> (raw)
This is an alternative approach to simplifying the crash information
patches.
Currently, crash information is exposed twice, through a QOM property
and through a method. This is because accessing QOM properties with
QAPI struct types is a huge pain in the neck. Patch 1 fixes this by
providing a simple and well-tested API, that takes care of integrating
the QOM->QObject->QAPI steps into a single function.
Patch 2 then eliminates the get_crash_info method. Patch 3 finally
cleans up qemu_system_guest_panicked by passing a CPUState* argument
instead of a GuestPanicInformation struct.
Paolo
v1->v2:
include missing changes to tests/qapi-schema/qapi-schema-test.out
tweaks to doc comments
wrap long lines
Paolo Bonzini (3):
qom-qobject: introduce object_property_{g,s}et_ptr
cpu: implement get_crash_info through QOM properties
vl: pass CPUState to qemu_system_guest_panicked
include/qom/cpu.h | 1 -
include/qom/qom-qobject.h | 68 +++++++++++-
include/sysemu/sysemu.h | 2 +-
kvm-all.c | 2 +-
qom/cpu.c | 11 +-
qom/qom-qobject.c | 52 ++++++++++
target/i386/cpu.c | 2 +-
tests/Makefile.include | 2 +-
tests/check-qom-proplist.c | 177 +++++++++++++++++++++++++++++++-
tests/qapi-schema/qapi-schema-test.json | 8 ++
tests/qapi-schema/qapi-schema-test.out | 6 ++
vl.c | 13 ++-
12 files changed, 326 insertions(+), 18 deletions(-)
--
2.9.3
next reply other threads:[~2017-02-22 18:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-22 18:04 Paolo Bonzini [this message]
2017-02-22 18:04 ` [Qemu-devel] [PATCH 1/3] qom-qobject: introduce object_property_{g, s}et_ptr Paolo Bonzini
2017-02-22 23:34 ` Eric Blake
2017-02-23 8:33 ` Marc-André Lureau
2017-02-24 14:54 ` Markus Armbruster
2017-02-24 15:29 ` Paolo Bonzini
2017-02-24 16:54 ` Eric Blake
2017-02-24 17:12 ` Paolo Bonzini
2017-02-24 19:18 ` Markus Armbruster
2017-02-22 18:04 ` [Qemu-devel] [PATCH 2/3] cpu: implement get_crash_info through QOM properties Paolo Bonzini
2017-02-22 18:04 ` [Qemu-devel] [PATCH 3/3] vl: pass CPUState to qemu_system_guest_panicked Paolo Bonzini
2017-02-22 18:13 ` [Qemu-devel] [PATCH v2 0/3] simplify struct QOM properties and use the result for GUEST_PANICKED no-reply
2017-02-23 8:34 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170222180423.26571-1-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=eblake@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).