Re: [Qemu-devel] [PATCH v2 0/3] do not use aio_context_acquire/release in AIO-based drivers

[Stefan Hajnoczi <stefanha@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1165 bytes --]

On Wed, Feb 22, 2017 at 07:07:22PM +0100, Paolo Bonzini wrote:
> aio_context_acquire/release are only going away as soon as the block layer
> becomes thread-safe, but we can already move away to other finer-grained
> mutex whenever possible.
> 
> These three drivers don't use coroutines, hence a QemuMutex is a fine
> primitive to use for protecting any per-BDS data in the libraries
> they use.  The QemuMutex must protect any fd handlers or bottom halves,
> and also the BlockDriver callbacks which were implicitly being called
> under aio_context_acquire.
> 
> Paolo
> 
> v1->v2: missing unlock in error paths (patch 2, Stefan)
> 
> Paolo Bonzini (3):
>   curl: do not use aio_context_acquire/release
>   nfs: do not use aio_context_acquire/release
>   iscsi: do not use aio_context_acquire/release
> 
>  block/curl.c  | 24 ++++++++++-------
>  block/iscsi.c | 83 +++++++++++++++++++++++++++++++++++++++++++++--------------
>  block/nfs.c   | 23 ++++++++++++++---
>  3 files changed, 98 insertions(+), 32 deletions(-)
> 
> -- 
> 2.9.3
> 

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]