qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kashyap Chamarthy <kchamart@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Adding an overlay with 'blockdev-add' fails with: "Parameter 'driver' is missing"
Date: Thu, 23 Feb 2017 17:33:15 +0100	[thread overview]
Message-ID: <20170223163315.w2nekel42grwtbkc@eukaryote> (raw)
In-Reply-To: <87ino1gcx2.fsf@dusky.pond.sub.org>

On Thu, Feb 23, 2017 at 04:11:21PM +0100, Markus Armbruster wrote:
> Kashyap Chamarthy <kchamart@redhat.com> writes:
> 
> > TL;DR: Using `blockdev-add` to create an overlay file succeeds with QEMU
> >        2.7.0, however the *same* test fails with QEMU from Git (plus a
> >        couple of patch series from mailing list).  Details below.
> 
> commit 0153d2f50bc2ad3f41810d838fcf66acbf10f07a
> Author: Kevin Wolf <kwolf@redhat.com>
> Date:   Fri Oct 7 17:05:04 2016 +0200
> 
>     block: Remove "options" indirection from blockdev-add

[...]

> Sorry for the confusion!  Early adopters always have the most fun ;)

Ah, I see, thanks for the pointer.

I tried to come up with the below JSON, after looking at the QAPI schema
documentation (from qemu/qapi/block-core.json), still I seem to be
tripping up somewhere.  Now it doesn't recognize the 'backing' option:

$ socat UNIX:./qmp-sock READLINE,history=$HOME/.qmp_history,prompt='QMP> '
[...]
QMP> {
QMP>   "execute":"blockdev-add",
QMP>   "arguments":{
QMP>     "driver":"qcow2",
QMP>     "node-name":"node1"
QMP>   },
QMP>   "file":{
QMP>     "driver":"file",
QMP>     "filename":"/export/target.qcow2"
QMP>   },
QMP>   "backing":{
QMP>     "driver":"qcow2",
QMP>     "file":{
QMP>       "driver":"file",
QMP>       "filename":"/export/base.qcow2"
QMP>     }
QMP>   }
QMP> }
{"error": {"class": "GenericError", "desc": "QMP input object member 'backing' is unexpected"}}
QMP> 

-- 
/kashyap

  reply	other threads:[~2017-02-23 16:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-23 14:40 [Qemu-devel] Adding an overlay with 'blockdev-add' fails with: "Parameter 'driver' is missing" Kashyap Chamarthy
2017-02-23 15:11 ` Markus Armbruster
2017-02-23 16:33   ` Kashyap Chamarthy [this message]
2017-02-23 16:51     ` Eric Blake
2017-02-24 10:53       ` Kashyap Chamarthy
2017-02-24 11:43         ` Kashyap Chamarthy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170223163315.w2nekel42grwtbkc@eukaryote \
    --to=kchamart@redhat.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).