* [Qemu-devel] [PATCH] docker: Install python2 explicitly in docker image
@ 2017-02-22 2:18 Fam Zheng
2017-02-22 7:58 ` Auger Eric
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Fam Zheng @ 2017-02-22 2:18 UTC (permalink / raw)
To: qemu-devel; +Cc: Alex Bennée, Fam Zheng, Auger Eric
Python is no longer installed implicitly, but the QEMU build system
requires it. List it in PACKAGES.
Reported-by: Auger Eric <eric.auger@redhat.com>
Signed-off-by: Fam Zheng <famz@redhat.com>
---
tests/docker/dockerfiles/fedora.docker | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker
index 478163b..c4f80ad 100644
--- a/tests/docker/dockerfiles/fedora.docker
+++ b/tests/docker/dockerfiles/fedora.docker
@@ -1,6 +1,6 @@
FROM fedora:latest
ENV PACKAGES \
- ccache git tar PyYAML sparse flex bison \
+ ccache git tar PyYAML sparse flex bison python2 \
glib2-devel pixman-devel zlib-devel SDL-devel libfdt-devel \
gcc gcc-c++ clang make perl which bc findutils \
mingw32-pixman mingw32-glib2 mingw32-gmp mingw32-SDL mingw32-pkg-config \
--
2.9.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] docker: Install python2 explicitly in docker image
2017-02-22 2:18 [Qemu-devel] [PATCH] docker: Install python2 explicitly in docker image Fam Zheng
@ 2017-02-22 7:58 ` Auger Eric
2017-02-22 8:56 ` Alex Bennée
2017-02-24 6:16 ` Fam Zheng
2 siblings, 0 replies; 5+ messages in thread
From: Auger Eric @ 2017-02-22 7:58 UTC (permalink / raw)
To: Fam Zheng, qemu-devel; +Cc: Alex Bennée
Hi Fam,
On 22/02/2017 03:18, Fam Zheng wrote:
> Python is no longer installed implicitly, but the QEMU build system
> requires it. List it in PACKAGES.
>
> Reported-by: Auger Eric <eric.auger@redhat.com>
> Signed-off-by: Fam Zheng <famz@redhat.com>
Tested-by: Eric Auger <eric.auger@redhat.com>
Thanks!
Eric
> ---
> tests/docker/dockerfiles/fedora.docker | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker
> index 478163b..c4f80ad 100644
> --- a/tests/docker/dockerfiles/fedora.docker
> +++ b/tests/docker/dockerfiles/fedora.docker
> @@ -1,6 +1,6 @@
> FROM fedora:latest
> ENV PACKAGES \
> - ccache git tar PyYAML sparse flex bison \
> + ccache git tar PyYAML sparse flex bison python2 \
> glib2-devel pixman-devel zlib-devel SDL-devel libfdt-devel \
> gcc gcc-c++ clang make perl which bc findutils \
> mingw32-pixman mingw32-glib2 mingw32-gmp mingw32-SDL mingw32-pkg-config \
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] docker: Install python2 explicitly in docker image
2017-02-22 2:18 [Qemu-devel] [PATCH] docker: Install python2 explicitly in docker image Fam Zheng
2017-02-22 7:58 ` Auger Eric
@ 2017-02-22 8:56 ` Alex Bennée
2017-02-22 9:19 ` Fam Zheng
2017-02-24 6:16 ` Fam Zheng
2 siblings, 1 reply; 5+ messages in thread
From: Alex Bennée @ 2017-02-22 8:56 UTC (permalink / raw)
To: Fam Zheng; +Cc: qemu-devel, Auger Eric
Fam Zheng <famz@redhat.com> writes:
> Python is no longer installed implicitly, but the QEMU build system
> requires it. List it in PACKAGES.
Doesn't fedora have a similar system to dpkg's build-deps that we should
use to install dependencies?
>
> Reported-by: Auger Eric <eric.auger@redhat.com>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> tests/docker/dockerfiles/fedora.docker | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker
> index 478163b..c4f80ad 100644
> --- a/tests/docker/dockerfiles/fedora.docker
> +++ b/tests/docker/dockerfiles/fedora.docker
> @@ -1,6 +1,6 @@
> FROM fedora:latest
> ENV PACKAGES \
> - ccache git tar PyYAML sparse flex bison \
> + ccache git tar PyYAML sparse flex bison python2 \
> glib2-devel pixman-devel zlib-devel SDL-devel libfdt-devel \
> gcc gcc-c++ clang make perl which bc findutils \
> mingw32-pixman mingw32-glib2 mingw32-gmp mingw32-SDL mingw32-pkg-config \
--
Alex Bennée
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] docker: Install python2 explicitly in docker image
2017-02-22 8:56 ` Alex Bennée
@ 2017-02-22 9:19 ` Fam Zheng
0 siblings, 0 replies; 5+ messages in thread
From: Fam Zheng @ 2017-02-22 9:19 UTC (permalink / raw)
To: Alex Bennée; +Cc: Auger Eric, qemu-devel
On Wed, 02/22 08:56, Alex Bennée wrote:
>
> Fam Zheng <famz@redhat.com> writes:
>
> > Python is no longer installed implicitly, but the QEMU build system
> > requires it. List it in PACKAGES.
>
> Doesn't fedora have a similar system to dpkg's build-deps that we should
> use to install dependencies?
It does, but I'm not sure how to generate PACKAGES out of that, for the SHOW_ENV
feature.
Fam
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] docker: Install python2 explicitly in docker image
2017-02-22 2:18 [Qemu-devel] [PATCH] docker: Install python2 explicitly in docker image Fam Zheng
2017-02-22 7:58 ` Auger Eric
2017-02-22 8:56 ` Alex Bennée
@ 2017-02-24 6:16 ` Fam Zheng
2 siblings, 0 replies; 5+ messages in thread
From: Fam Zheng @ 2017-02-24 6:16 UTC (permalink / raw)
To: qemu-devel; +Cc: Alex Bennée, Auger Eric
On Wed, 02/22 10:18, Fam Zheng wrote:
> Python is no longer installed implicitly, but the QEMU build system
> requires it. List it in PACKAGES.
>
> Reported-by: Auger Eric <eric.auger@redhat.com>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> tests/docker/dockerfiles/fedora.docker | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker
> index 478163b..c4f80ad 100644
> --- a/tests/docker/dockerfiles/fedora.docker
> +++ b/tests/docker/dockerfiles/fedora.docker
> @@ -1,6 +1,6 @@
> FROM fedora:latest
> ENV PACKAGES \
> - ccache git tar PyYAML sparse flex bison \
> + ccache git tar PyYAML sparse flex bison python2 \
> glib2-devel pixman-devel zlib-devel SDL-devel libfdt-devel \
> gcc gcc-c++ clang make perl which bc findutils \
> mingw32-pixman mingw32-glib2 mingw32-gmp mingw32-SDL mingw32-pkg-config \
> --
> 2.9.3
>
Applied to my staging tree.
Fam
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-02-24 6:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-22 2:18 [Qemu-devel] [PATCH] docker: Install python2 explicitly in docker image Fam Zheng
2017-02-22 7:58 ` Auger Eric
2017-02-22 8:56 ` Alex Bennée
2017-02-22 9:19 ` Fam Zheng
2017-02-24 6:16 ` Fam Zheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).