Re: [Qemu-devel] [PATCH 37/43] spapr: reuse machine->possible_cpus instead of cores[]

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1560 bytes --]

On Fri, Feb 24, 2017 at 02:29:21PM +0100, Igor Mammedov wrote:
> On Sat, 25 Feb 2017 00:03:57 +1100
> David Gibson <david@gibson.dropbear.id.au> wrote:
> 
> > On Wed, Feb 22, 2017 at 12:05:55PM +0100, Igor Mammedov wrote:
> > > Replace SPAPR specific cores[] array with generic
> > > machine->possible_cpus and store core objects there.
> > > It makes cores bookkeeping similar to x86 cpus and
> > > will allow to unify similar code.
> > > It would allow to replace cpu_index based NUMA node
> > > mapping with property based one (for -device created
> > > cores) since possible_cpus carries board defined
> > > topology/layout.
> > > 
> > > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> > > Acked-by: David Gibson <david@gibson.dropbear.id.au>
> > > Signed-off-by: David Gibson <david@gibson.dropbear.id.au>  
> > 
> > Sorry Igor, Peter has applied the original version.  Can you resend
> > these updates as deltas against the applied versions of the patches.
> > 
> > > ---
> > > v3:
> > >   - drop "// TODO" comment as todo is completed in next patch anyway
> > >     fixes checkpatch error wrt // comment
> there is no need for patches on top as the next applied patch
> 38/43 removed c++ style comment as part of removed
> spapr_query_hotpluggable_cpus().

Ok, good to hear.  What about the other update patch you posted?

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]