From: David Gibson <david@gibson.dropbear.id.au>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Eric Blake <eblake@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] using fdt_setprop() to set properties to empty values
Date: Mon, 27 Feb 2017 12:05:28 +1100 [thread overview]
Message-ID: <20170227010528.GM17615@umbus.fritz.box> (raw)
In-Reply-To: <CAFEAcA9V_1NA6-JgZd7Pc1hwih+uBKBrt4MPi4+kPWRu-xduPA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1375 bytes --]
On Fri, Feb 24, 2017 at 10:35:35AM +0000, Peter Maydell wrote:
> On 24 February 2017 at 00:16, David Gibson <david@gibson.dropbear.id.au> wrote:
> > Ok, I've pushed libfdt upstream patches to (a) make passing NULL to
> > setprop() with zero length explicitly safe and (b) add an
> > fdt_setprop_empty() helper macro. Do you want me to make a pullreq to
> > update the qemu submodule?
>
> Yes, please. Are we OK with using a random libfdt commit or do
> we update only to proper release tags?
I'm find with a random SHA, but that's not really my department - I'm
upstream libfdt maintainer, but update policy in the qemu tree seems
like a qemu side decision.
> There's no real rush with
> this so if you have a release due shortly it might be better
> to wait for that.
dtc/libfdt releases are a rather haphazard affair. Usually they
happen when somebody complains that there hasn't been a release with
some feature they want. Our tests are both fast to run and have
reasonaably good coverage, so random commits are usually good. So a
"release" is usually just slapping a new version number onto whatever
is in master and making a tag and tarball.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2017-02-27 1:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-23 12:33 [Qemu-devel] using fdt_setprop() to set properties to empty values Peter Maydell
2017-02-23 14:52 ` Eric Blake
2017-02-23 22:49 ` David Gibson
2017-02-24 0:16 ` David Gibson
2017-02-24 10:35 ` Peter Maydell
2017-02-27 1:05 ` David Gibson [this message]
2017-02-27 10:11 ` Peter Maydell
2017-03-01 0:16 ` David Gibson
2017-03-01 1:17 ` David Gibson
2017-03-03 6:30 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170227010528.GM17615@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=eblake@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).