From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52283) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ciLWa-00075P-TU for qemu-devel@nongnu.org; Mon, 27 Feb 2017 08:39:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ciLWZ-0000S9-RW for qemu-devel@nongnu.org; Mon, 27 Feb 2017 08:39:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56238) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ciLWZ-0000S4-LX for qemu-devel@nongnu.org; Mon, 27 Feb 2017 08:39:35 -0500 From: "Daniel P. Berrange" Date: Mon, 27 Feb 2017 13:39:26 +0000 Message-Id: <20170227133927.759-2-berrange@redhat.com> In-Reply-To: <20170227133927.759-1-berrange@redhat.com> References: <20170227133927.759-1-berrange@redhat.com> Subject: [Qemu-devel] [PULL v1 1/2] crypto: fix leak in ivgen essiv init List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , Li Qiang , "Daniel P . Berrange" From: Li Qiang On error path, the 'salt' doesn't been freed thus leading a memory leak. This patch avoid this. Signed-off-by: Li Qiang Signed-off-by: Daniel P. Berrange --- crypto/ivgen-essiv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/crypto/ivgen-essiv.c b/crypto/ivgen-essiv.c index 634de63..cba20bd 100644 --- a/crypto/ivgen-essiv.c +++ b/crypto/ivgen-essiv.c @@ -48,6 +48,7 @@ static int qcrypto_ivgen_essiv_init(QCryptoIVGen *ivgen, &salt, &nhash, errp) < 0) { g_free(essiv); + g_free(salt); return -1; } -- 2.9.3