qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <rth@twiddle.net>,
	qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 03/11] i386: Rename X86CPU::host_features to X86CPU::max_features
Date: Mon, 27 Feb 2017 13:24:53 -0300	[thread overview]
Message-ID: <20170227162501.29280-4-ehabkost@redhat.com> (raw)
In-Reply-To: <20170227162501.29280-1-ehabkost@redhat.com>

Rename the field and add a small comment to make its purpose
clearer.

Message-Id: <20170119210449.11991-4-ehabkost@redhat.com>
Tested-by: Jiri Denemark <jdenemar@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 target/i386/cpu.h | 2 +-
 target/i386/cpu.c | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/target/i386/cpu.h b/target/i386/cpu.h
index 8df124f332..5f75ab1b15 100644
--- a/target/i386/cpu.h
+++ b/target/i386/cpu.h
@@ -1211,7 +1211,7 @@ struct X86CPU {
     bool enforce_cpuid;
     bool expose_kvm;
     bool migratable;
-    bool host_features;
+    bool max_features; /* Enable all supported features automatically */
     uint32_t apic_id;
 
     /* Enables publishing of TSC increment and Local APIC bus frequencies to
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 8efe4de89e..87affbfcd6 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -1583,7 +1583,7 @@ static void host_x86_cpu_initfn(Object *obj)
     /* We can't fill the features array here because we don't know yet if
      * "migratable" is true or false.
      */
-    cpu->host_features = true;
+    cpu->max_features = true;
 
     /* If KVM is disabled, x86_cpu_realizefn() will report an error later */
     if (kvm_enabled()) {
@@ -3101,12 +3101,12 @@ static void x86_cpu_load_features(X86CPU *cpu, Error **errp)
     GList *l;
     Error *local_err = NULL;
 
-    /*TODO: cpu->host_features incorrectly overwrites features
+    /*TODO: cpu->max_features incorrectly overwrites features
      * set using "feat=on|off". Once we fix this, we can convert
      * plus_features & minus_features to global properties
      * inside x86_cpu_parse_featurestr() too.
      */
-    if (cpu->host_features) {
+    if (cpu->max_features) {
         for (w = 0; w < FEATURE_WORDS; w++) {
             env->features[w] =
                 x86_cpu_get_supported_feature_word(w, cpu->migratable);
-- 
2.11.0.259.g40922b1

  parent reply	other threads:[~2017-02-27 16:25 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-27 16:24 [Qemu-devel] [PULL 00/11] x86 queue, 2017-02-27 Eduardo Habkost
2017-02-27 16:24 ` [Qemu-devel] [PULL 01/11] i386: Unset cannot_destroy_with_object_finalize_yet on "host" model Eduardo Habkost
2017-02-27 16:24 ` [Qemu-devel] [PULL 02/11] i386: Add ordering field to CPUClass Eduardo Habkost
2017-02-27 16:24 ` Eduardo Habkost [this message]
2017-02-27 16:24 ` [Qemu-devel] [PULL 04/11] i386: Reorganize and document CPUID initialization steps Eduardo Habkost
2017-02-27 16:24 ` [Qemu-devel] [PULL 05/11] qapi-schema: Comment about full expansion of non-migration-safe models Eduardo Habkost
2017-02-27 16:24 ` [Qemu-devel] [PULL 06/11] i386: Create "max" CPU model Eduardo Habkost
2017-02-27 16:24 ` [Qemu-devel] [PULL 07/11] i386: Make "max" model not use any host CPUID info on TCG Eduardo Habkost
2017-02-27 16:24 ` [Qemu-devel] [PULL 08/11] i386: Don't set CPUClass::cpu_def on "max" model Eduardo Habkost
2017-02-27 16:24 ` [Qemu-devel] [PULL 09/11] i386: Define static "base" CPU model Eduardo Habkost
2017-02-27 16:25 ` [Qemu-devel] [PULL 10/11] i386: Implement query-cpu-model-expansion QMP command Eduardo Habkost
2017-02-27 16:25 ` [Qemu-devel] [PULL 11/11] i386: Improve query-cpu-model-expansion full mode Eduardo Habkost
2017-02-27 19:16 ` [Qemu-devel] [PULL 00/11] x86 queue, 2017-02-27 Peter Maydell
2017-02-27 19:41   ` [Qemu-devel] travis-ci 'make check' timeouts (was Re: [PULL 00/11] x86 queue, 2017-02-27) Eduardo Habkost
2017-02-27 19:57     ` Greg Kurz
2017-02-28 19:12       ` Eduardo Habkost
2017-02-28 19:17         ` Peter Maydell
2017-03-02 15:39           ` Eduardo Habkost
2017-03-02 15:54             ` Paolo Bonzini
2017-03-02 16:07               ` Eduardo Habkost
2017-03-02 16:16                 ` Peter Maydell
2017-03-02 18:00                   ` Eduardo Habkost
2017-03-02 16:22                 ` Paolo Bonzini
2017-03-02 12:29   ` [Qemu-devel] [PULL 00/11] x86 queue, 2017-02-27 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170227162501.29280-4-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).