* [Qemu-devel] [PATCH] block/mirror: fix broken sparseness detection
@ 2017-02-27 17:13 John Snow
2017-02-27 19:00 ` Jeff Cody
2017-02-27 19:03 ` Jeff Cody
0 siblings, 2 replies; 3+ messages in thread
From: John Snow @ 2017-02-27 17:13 UTC (permalink / raw)
To: qemu-block; +Cc: kwolf, jcody, qemu-devel, mreitz, John Snow
int64_t is in all likelihood the actual scalar type we want.
Yep, really.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1219541
Signed-off-by: John Snow <jsnow@redhat.com>
---
block/mirror.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/mirror.c b/block/mirror.c
index ca8547b..7b4cfbd 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -386,7 +386,7 @@ static uint64_t coroutine_fn mirror_iteration(MirrorBlockJob *s)
nb_chunks * sectors_per_chunk);
bitmap_set(s->in_flight_bitmap, sector_num / sectors_per_chunk, nb_chunks);
while (nb_chunks > 0 && sector_num < end) {
- int ret;
+ int64_t ret;
int io_sectors, io_sectors_acct;
BlockDriverState *file;
enum MirrorMethod {
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] block/mirror: fix broken sparseness detection
2017-02-27 17:13 [Qemu-devel] [PATCH] block/mirror: fix broken sparseness detection John Snow
@ 2017-02-27 19:00 ` Jeff Cody
2017-02-27 19:03 ` Jeff Cody
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Cody @ 2017-02-27 19:00 UTC (permalink / raw)
To: John Snow; +Cc: qemu-block, kwolf, qemu-devel, mreitz
On Mon, Feb 27, 2017 at 12:13:14PM -0500, John Snow wrote:
> int64_t is in all likelihood the actual scalar type we want.
> Yep, really.
>
> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1219541
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> block/mirror.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/mirror.c b/block/mirror.c
> index ca8547b..7b4cfbd 100644
> --- a/block/mirror.c
> +++ b/block/mirror.c
> @@ -386,7 +386,7 @@ static uint64_t coroutine_fn mirror_iteration(MirrorBlockJob *s)
> nb_chunks * sectors_per_chunk);
> bitmap_set(s->in_flight_bitmap, sector_num / sectors_per_chunk, nb_chunks);
> while (nb_chunks > 0 && sector_num < end) {
> - int ret;
> + int64_t ret;
> int io_sectors, io_sectors_acct;
> BlockDriverState *file;
> enum MirrorMethod {
> --
> 2.9.3
>
Reviewed-by: Jeff Cody <jcody@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] block/mirror: fix broken sparseness detection
2017-02-27 17:13 [Qemu-devel] [PATCH] block/mirror: fix broken sparseness detection John Snow
2017-02-27 19:00 ` Jeff Cody
@ 2017-02-27 19:03 ` Jeff Cody
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Cody @ 2017-02-27 19:03 UTC (permalink / raw)
To: John Snow; +Cc: qemu-block, kwolf, qemu-devel, mreitz
On Mon, Feb 27, 2017 at 12:13:14PM -0500, John Snow wrote:
> int64_t is in all likelihood the actual scalar type we want.
> Yep, really.
>
> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1219541
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> block/mirror.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/mirror.c b/block/mirror.c
> index ca8547b..7b4cfbd 100644
> --- a/block/mirror.c
> +++ b/block/mirror.c
> @@ -386,7 +386,7 @@ static uint64_t coroutine_fn mirror_iteration(MirrorBlockJob *s)
> nb_chunks * sectors_per_chunk);
> bitmap_set(s->in_flight_bitmap, sector_num / sectors_per_chunk, nb_chunks);
> while (nb_chunks > 0 && sector_num < end) {
> - int ret;
> + int64_t ret;
> int io_sectors, io_sectors_acct;
> BlockDriverState *file;
> enum MirrorMethod {
> --
> 2.9.3
>
Thanks,
Applied to my block branch:
git://github.com/codyprime/qemu-kvm-jtc.git block
-Jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-27 19:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-27 17:13 [Qemu-devel] [PATCH] block/mirror: fix broken sparseness detection John Snow
2017-02-27 19:00 ` Jeff Cody
2017-02-27 19:03 ` Jeff Cody
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).