From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36870) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ciQXY-0006xE-8x for qemu-devel@nongnu.org; Mon, 27 Feb 2017 14:00:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ciQXX-0004Yy-6Z for qemu-devel@nongnu.org; Mon, 27 Feb 2017 14:00:56 -0500 Date: Mon, 27 Feb 2017 14:00:47 -0500 From: Jeff Cody Message-ID: <20170227190047.GH25637@localhost.localdomain> References: <20170227171314.9518-1-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170227171314.9518-1-jsnow@redhat.com> Subject: Re: [Qemu-devel] [PATCH] block/mirror: fix broken sparseness detection List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: qemu-block@nongnu.org, kwolf@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com On Mon, Feb 27, 2017 at 12:13:14PM -0500, John Snow wrote: > int64_t is in all likelihood the actual scalar type we want. > Yep, really. > > Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1219541 > > Signed-off-by: John Snow > --- > block/mirror.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/mirror.c b/block/mirror.c > index ca8547b..7b4cfbd 100644 > --- a/block/mirror.c > +++ b/block/mirror.c > @@ -386,7 +386,7 @@ static uint64_t coroutine_fn mirror_iteration(MirrorBlockJob *s) > nb_chunks * sectors_per_chunk); > bitmap_set(s->in_flight_bitmap, sector_num / sectors_per_chunk, nb_chunks); > while (nb_chunks > 0 && sector_num < end) { > - int ret; > + int64_t ret; > int io_sectors, io_sectors_acct; > BlockDriverState *file; > enum MirrorMethod { > -- > 2.9.3 > Reviewed-by: Jeff Cody