From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54727) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cieQS-0007Ek-Gg for qemu-devel@nongnu.org; Tue, 28 Feb 2017 04:50:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cieQN-0007Ys-Ia for qemu-devel@nongnu.org; Tue, 28 Feb 2017 04:50:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55602) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cieQN-0007YR-Cb for qemu-devel@nongnu.org; Tue, 28 Feb 2017 04:50:27 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 53439FAF56 for ; Tue, 28 Feb 2017 09:50:27 +0000 (UTC) Date: Tue, 28 Feb 2017 09:50:22 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20170228095022.GD2773@work-vm> References: <20170221141451.28305-1-marcandre.lureau@redhat.com> <20170221141451.28305-31-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20170221141451.28305-31-marcandre.lureau@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 30/30] migration: fix id leak regression List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?Marc-Andr=E9?= Lureau Cc: qemu-devel@nongnu.org, Juan Quintela * Marc-Andr=E9 Lureau (marcandre.lureau@redhat.com) wrote: > This leak was introduced in commit > 581f08bac22bdd5e081ae07f68071a0fc3c5c2c7. >=20 > (it stands out quickly with ASAN once the rest of the leaks are also > removed from make check with this series) >=20 > Cc: Dr. David Alan Gilbert > Cc: Juan Quintela > Signed-off-by: Marc-Andr=E9 Lureau Queued just this one. > --- > migration/savevm.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/migration/savevm.c b/migration/savevm.c > index 5ecd264134..87c7a00832 100644 > --- a/migration/savevm.c > +++ b/migration/savevm.c > @@ -688,6 +688,7 @@ int vmstate_register_with_alias_id(DeviceState *dev= , int instance_id, > =20 > return -1; > } > + g_free(id); > =20 > se->compat =3D g_new0(CompatEntry, 1); > pstrcpy(se->compat->idstr, sizeof(se->compat->idstr), vmsd= ->name); > --=20 > 2.11.0.295.gd7dffce1c.dirty >=20 >=20 -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK