From: Fam Zheng <famz@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-block@nongnu.org, mreitz@redhat.com, jcody@redhat.com,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 00/44] New op blocker system, part 1
Date: Tue, 28 Feb 2017 22:24:40 +0800 [thread overview]
Message-ID: <20170228142440.GA2344@lemon.lan> (raw)
In-Reply-To: <1488286469-9381-1-git-send-email-kwolf@redhat.com>
On Tue, 02/28 13:53, Kevin Wolf wrote:
> This series is the first part of implementing the new op blocker system
> whose design was agreed on quite a while ago, but proved a bit tricky to
> implement in places. There is more work to do to fully replace the old op
> blocker system, but realistically we don't have that much time until the 2.9
> freeze. So let's merge this series to complement the traditional op blockers
> and plan with a second part for the 2.10 timeframe.
If we don't merge this, what should we do during the lengthy winter^Wfreeze? ;-)
Seriously, the series looks pretty good to me. I didn't leave my rev-by patch by
patch when reviewing previous versions, because I focused on my overall
happiness on the API (frankly, I was a bit skeptical about the apparent
complexity of this at the first sight). Now that I think I am happy, and also as
I don't have time for a blanket review on the whole series today that upholds a
full rev-by, I'm going to give:
Acked-by: Fam Zheng <famz@redhat.com>
prev parent reply other threads:[~2017-02-28 14:24 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 12:53 [Qemu-devel] [PATCH v3 00/44] New op blocker system, part 1 Kevin Wolf
2017-02-28 12:53 ` [Qemu-devel] [PATCH v3 01/44] block: Add op blocker permission constants Kevin Wolf
2017-02-28 12:53 ` [Qemu-devel] [PATCH v3 02/44] block: Add Error argument to bdrv_attach_child() Kevin Wolf
2017-02-28 12:53 ` [Qemu-devel] [PATCH v3 03/44] block: Let callers request permissions when attaching a child node Kevin Wolf
2017-02-28 12:53 ` [Qemu-devel] [PATCH v3 04/44] block: Involve block drivers in permission granting Kevin Wolf
2017-02-28 14:53 ` Max Reitz
2017-02-28 12:53 ` [Qemu-devel] [PATCH v3 05/44] block: Default .bdrv_child_perm() for filter drivers Kevin Wolf
2017-02-28 15:00 ` Max Reitz
2017-02-28 12:53 ` [Qemu-devel] [PATCH v3 06/44] block: Request child permissions in " Kevin Wolf
2017-02-28 12:53 ` [Qemu-devel] [PATCH v3 07/44] block: Default .bdrv_child_perm() for format drivers Kevin Wolf
2017-02-28 15:01 ` Max Reitz
2017-02-28 12:53 ` [Qemu-devel] [PATCH v3 08/44] block: Request child permissions in " Kevin Wolf
2017-02-28 12:53 ` [Qemu-devel] [PATCH v3 09/44] vvfat: Implement .bdrv_child_perm() Kevin Wolf
2017-02-28 12:53 ` [Qemu-devel] [PATCH v3 10/44] block: Require .bdrv_child_perm() with child nodes Kevin Wolf
2017-02-28 12:53 ` [Qemu-devel] [PATCH v3 11/44] block: Request real permissions in bdrv_attach_child() Kevin Wolf
2017-02-28 15:04 ` Max Reitz
2017-02-28 12:53 ` [Qemu-devel] [PATCH v3 12/44] block: Add permissions to BlockBackend Kevin Wolf
2017-02-28 12:53 ` [Qemu-devel] [PATCH v3 13/44] block: Add permissions to blk_new() Kevin Wolf
2017-02-28 12:53 ` [Qemu-devel] [PATCH v3 14/44] block: Add error parameter to blk_insert_bs() Kevin Wolf
2017-02-28 12:54 ` [Qemu-devel] [PATCH v3 15/44] block: Add BDRV_O_RESIZE for blk_new_open() Kevin Wolf
2017-02-28 15:07 ` Max Reitz
2017-02-28 12:54 ` [Qemu-devel] [PATCH v3 16/44] block: Request real permissions in blk_new_open() Kevin Wolf
2017-02-28 12:54 ` [Qemu-devel] [PATCH v3 17/44] block: Allow error return in BlockDevOps.change_media_cb() Kevin Wolf
2017-02-28 12:54 ` [Qemu-devel] [PATCH v3 18/44] hw/block: Request permissions Kevin Wolf
2017-02-28 15:10 ` Max Reitz
2017-02-28 12:54 ` [Qemu-devel] [PATCH v3 19/44] hw/block: Introduce share-rw qdev property Kevin Wolf
2017-02-28 12:54 ` [Qemu-devel] [PATCH v3 20/44] blockjob: Add permissions to block_job_create() Kevin Wolf
2017-02-28 12:54 ` [Qemu-devel] [PATCH v3 21/44] block: Add BdrvChildRole.get_parent_desc() Kevin Wolf
2017-02-28 12:54 ` [Qemu-devel] [PATCH v3 22/44] block: Include details on permission errors in message Kevin Wolf
2017-02-28 15:18 ` Max Reitz
2017-02-28 12:54 ` [Qemu-devel] [PATCH v3 23/44] block: Add BdrvChildRole.stay_at_node Kevin Wolf
2017-02-28 12:54 ` [Qemu-devel] [PATCH v3 24/44] blockjob: Add permissions to block_job_add_bdrv() Kevin Wolf
2017-02-28 12:54 ` [Qemu-devel] [PATCH v3 25/44] commit: Use real permissions in commit block job Kevin Wolf
2017-02-28 15:29 ` Max Reitz
2017-02-28 12:54 ` [Qemu-devel] [PATCH v3 26/44] commit: Use real permissions for HMP 'commit' Kevin Wolf
2017-02-28 12:54 ` [Qemu-devel] [PATCH v3 27/44] backup: Use real permissions in backup block job Kevin Wolf
2017-02-28 12:54 ` [Qemu-devel] [PATCH v3 28/44] block: Fix pending requests check in bdrv_append() Kevin Wolf
2017-10-04 10:24 ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2017-02-28 12:54 ` [Qemu-devel] [PATCH v3 29/44] block: BdrvChildRole.attach/detach() callbacks Kevin Wolf
2017-02-28 12:54 ` [Qemu-devel] [PATCH v3 30/44] block: Allow backing file links in change_parent_backing_link() Kevin Wolf
2017-02-28 12:54 ` [Qemu-devel] [PATCH v3 31/44] blockjob: Factor out block_job_remove_all_bdrv() Kevin Wolf
2017-02-28 15:38 ` Max Reitz
2017-02-28 12:54 ` [Qemu-devel] [PATCH v3 32/44] mirror: Use real permissions in mirror/active commit block job Kevin Wolf
2017-02-28 15:50 ` Max Reitz
2017-02-28 12:54 ` [Qemu-devel] [PATCH v3 33/44] stream: Use real permissions in streaming " Kevin Wolf
2017-02-28 12:54 ` [Qemu-devel] [PATCH v3 34/44] mirror: Add filter-node-name to blockdev-mirror Kevin Wolf
2017-02-28 12:54 ` [Qemu-devel] [PATCH v3 35/44] commit: Add filter-node-name to block-commit Kevin Wolf
2017-02-28 15:56 ` Max Reitz
2017-02-28 12:54 ` [Qemu-devel] [PATCH v3 36/44] hmp: Request permissions in qemu-io Kevin Wolf
2017-02-28 12:54 ` [Qemu-devel] [PATCH v3 37/44] migration/block: Use real permissions Kevin Wolf
2017-02-28 16:00 ` Max Reitz
2017-02-28 12:54 ` [Qemu-devel] [PATCH v3 38/44] nbd/server: Use real permissions for NBD exports Kevin Wolf
2017-02-28 12:54 ` [Qemu-devel] [PATCH v3 39/44] tests: Remove FIXME comments Kevin Wolf
2017-02-28 12:54 ` [Qemu-devel] [PATCH v3 40/44] block: Pass BdrvChild to bdrv_aligned_preadv/pwritev and copy-on-read Kevin Wolf
2017-02-28 16:05 ` Max Reitz
2017-02-28 12:54 ` [Qemu-devel] [PATCH v3 41/44] block: Assertions for write permissions Kevin Wolf
2017-02-28 16:06 ` Max Reitz
2017-02-28 12:54 ` [Qemu-devel] [PATCH v3 42/44] block: Assertions for resize permission Kevin Wolf
2017-02-28 12:54 ` [Qemu-devel] [PATCH v3 43/44] block: Add Error parameter to bdrv_set_backing_hd() Kevin Wolf
2017-02-28 16:20 ` Max Reitz
2017-02-28 12:54 ` [Qemu-devel] [PATCH v3 44/44] block: Add Error parameter to bdrv_append() Kevin Wolf
2017-02-28 16:22 ` Max Reitz
2017-02-28 14:24 ` Fam Zheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170228142440.GA2344@lemon.lan \
--to=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).