qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Hervé Poussineau" <hpoussin@reactos.org>
Subject: [Qemu-devel] [PULL 19/19] vl: disable default cdrom when using explicitely scsi-hd
Date: Tue, 28 Feb 2017 17:14:02 +0100	[thread overview]
Message-ID: <20170228161402.25122-4-pbonzini@redhat.com> (raw)
In-Reply-To: <20170228161402.25122-1-pbonzini@redhat.com>

From: Hervé Poussineau <hpoussin@reactos.org>

In commit af6bf1328ef90fae617857c02697e0174b84d596 (May 2011),
ide-hd, ide-cd and scsi-cd have been added to disable default cdrom,
"or else you can't put one on secondary master without -nodefaults".

Make it the same for scsi-hd, so you can put one on scsi-id 2 without
using -nodefaults.
scsi-hd has probably been forgotten, as it has been added in the
preceding commit (b443ae67130d32ad06b06fc9aa6d04d05ccd93ce).

Affected users are the ones using a machine with SCSI devices and start QEMU
with -device scsi-hd but without -device scsi-cd or -cdrom
In that case, the default cdrom device will disappear instead of being empty.

Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
Message-Id: <1487623279-29930-1-git-send-email-hpoussin@reactos.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 vl.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/vl.c b/vl.c
index 7f57ded..16a3b5e 100644
--- a/vl.c
+++ b/vl.c
@@ -227,6 +227,7 @@ static struct {
     { .driver = "ide-hd",               .flag = &default_cdrom     },
     { .driver = "ide-drive",            .flag = &default_cdrom     },
     { .driver = "scsi-cd",              .flag = &default_cdrom     },
+    { .driver = "scsi-hd",              .flag = &default_cdrom     },
     { .driver = "virtio-serial-pci",    .flag = &default_virtcon   },
     { .driver = "virtio-serial",        .flag = &default_virtcon   },
     { .driver = "VGA",                  .flag = &default_vga       },
-- 
2.9.3

  parent reply	other threads:[~2017-02-28 16:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-28 16:13 [Qemu-devel] [PULL v4 00/19] KVM and cpu-exec patches for 2.9 soft freeze Paolo Bonzini
2017-02-28 16:14 ` [Qemu-devel] [PULL 10/19] KVM: do not use sigtimedwait to catch SIGBUS Paolo Bonzini
2017-02-28 16:14 ` [Qemu-devel] [PULL 18/19] memory: Introduce DEVICE_HOST_ENDIAN for ram device Paolo Bonzini
2017-02-28 16:14 ` Paolo Bonzini [this message]
2017-03-01 17:58 ` [Qemu-devel] [PULL v4 00/19] KVM and cpu-exec patches for 2.9 soft freeze Peter Maydell
2017-03-02 18:01   ` Paolo Bonzini
2017-03-02 23:20     ` Peter Maydell
  -- strict thread matches above, loose matches on Subject: below --
2017-03-01 12:29 Paolo Bonzini
2017-03-01 12:29 ` [Qemu-devel] [PULL 19/19] vl: disable default cdrom when using explicitely scsi-hd Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170228161402.25122-4-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=hpoussin@reactos.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).