From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53397) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cikfR-0000df-5R for qemu-devel@nongnu.org; Tue, 28 Feb 2017 11:30:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cikfQ-0000id-Bq for qemu-devel@nongnu.org; Tue, 28 Feb 2017 11:30:25 -0500 Date: Tue, 28 Feb 2017 11:30:17 -0500 From: Jeff Cody Message-ID: <20170228163017.GE15696@localhost.localdomain> References: <20170228161553.28142-1-jcody@redhat.com> <20170228161553.28142-6-jcody@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PULL 5/5] block/rbd: add support for 'mon_host', 'auth_supported' via QAPI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-block@nongnu.org, peter.maydell@linaro.org, qemu-devel@nongnu.org On Tue, Feb 28, 2017 at 10:26:49AM -0600, Eric Blake wrote: > On 02/28/2017 10:15 AM, Jeff Cody wrote: > > This adds support for three additional options that may be specified > > by QAPI in blockdev-add: > > > > server: host, port > > auth method: either 'cephx' or 'none' > > > > The "server" and "auth-supported" QAPI parameters are arrays. To conform > > with the rados API, the array items are join as a single string with a ';' > > character as a delimiter when setting the configuration values. > > > > Reviewed-by: Markus Armbruster > > What happened to Signed-off-by? You'll have to resubmit the pull request > Argh, thanks - that is what happens when I go outside my normal workflow. Will send a v2 pr > > --- > > block/rbd.c | 134 +++++++++++++++++++++++++++++++++++++++++++++++++++ > > qapi/block-core.json | 29 +++++++++++ > > 2 files changed, 163 insertions(+) > > > > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org >