qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Nini Gu <ngu@redhat.com>,
	qemu-block@nongnu.org, Alberto Garcia <berto@igalia.com>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH v3 0/3] throttle: improve command-line parameter documentation
Date: Wed,  1 Mar 2017 11:50:23 +0000	[thread overview]
Message-ID: <20170301115026.22621-1-stefanha@redhat.com> (raw)

v3:
 * Added Patch 2 to fix invalid test parameters
 * Switched to nicer max < avg check [Berto]
v2:
 * Fixed s/bps/iops/ copy-paste error in Patch 1 [Berto]
 * Rephrased warning about guest hangs and errors [Berto]
 * Added Patch 2 to hide the internal .max value from the monitor

Patch 1 fleshes out the documentation for I/O throttling command-line
parameters.

Patch 2 hides an internal value that was being exposed to users via the
monitor and caused confusion.

I ended up not adding QMP-style throttling.* names to the command-line
documentation because the names are very long and unlikely to be used.  I
couldn't see a nice way of adding them while still keeping the documentation
readable.

Stefan Hajnoczi (3):
  qemu-options: explain disk I/O throttling options
  throttle: do not use invalid config in test
  throttle: make throttle_config(throttle_get_config()) symmetric

 tests/test-throttle.c |  8 ++++----
 util/throttle.c       | 14 ++++++++++++++
 qemu-options.hx       | 24 ++++++++++++++++++++++++
 3 files changed, 42 insertions(+), 4 deletions(-)

-- 
2.9.3

             reply	other threads:[~2017-03-01 11:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-01 11:50 Stefan Hajnoczi [this message]
2017-03-01 11:50 ` [Qemu-devel] [PATCH v3 1/3] qemu-options: explain disk I/O throttling options Stefan Hajnoczi
2017-03-01 13:07   ` Alberto Garcia
2017-03-01 21:29   ` Greg Kurz
2017-03-01 11:50 ` [Qemu-devel] [PATCH v3 2/3] throttle: do not use invalid config in test Stefan Hajnoczi
2017-03-01 12:29   ` Alberto Garcia
2017-03-01 11:50 ` [Qemu-devel] [PATCH v3 3/3] throttle: make throttle_config(throttle_get_config()) symmetric Stefan Hajnoczi
2017-03-01 12:30   ` Alberto Garcia
2017-03-01 21:27 ` [Qemu-devel] [PATCH v3 0/3] throttle: improve command-line parameter documentation Greg Kurz
2017-03-03  2:11   ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-03-03  7:01     ` Greg Kurz
2017-03-03  2:21 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170301115026.22621-1-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=berto@igalia.com \
    --cc=ngu@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).