From: "Daniel P. Berrange" <berrange@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
"Markus Armbruster" <armbru@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/2] Fix stale 'trace-events-all' file in build dir
Date: Wed, 1 Mar 2017 12:20:36 +0000 [thread overview]
Message-ID: <20170301122036.GB10160@redhat.com> (raw)
In-Reply-To: <20170301121934.GD29473@stefanha-x1.localdomain>
On Wed, Mar 01, 2017 at 12:19:34PM +0000, Stefan Hajnoczi wrote:
> On Tue, Feb 28, 2017 at 12:28:59PM +0000, Daniel P. Berrange wrote:
> > If systemtap support was disabled, the trace-events-all file was
> > only getting regenerated at time of 'make instal'. This is bad
> > because it leaves stale files in the build dir for developers.
> >
> > Daniel P. Berrange (2):
> > makefile: merge GENERATED_HEADERS & GENERATED_SOURCES variables
> > makefile: generate trace-events-all upfront
> >
> > Makefile | 39 +++++++++++++++++++--------------------
> > Makefile.target | 6 +++---
> > target/s390x/Makefile.objs | 2 +-
> > tests/Makefile.include | 2 +-
> > 4 files changed, 24 insertions(+), 25 deletions(-)
> >
> > --
> > 2.9.3
> >
> >
>
> Thanks, applied to my tracing tree:
> https://github.com/stefanha/qemu/commits/tracing
Could you apply the two typo fixes eric mentioned on the commit message
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
prev parent reply other threads:[~2017-03-01 12:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 12:28 [Qemu-devel] [PATCH 0/2] Fix stale 'trace-events-all' file in build dir Daniel P. Berrange
2017-02-28 12:29 ` [Qemu-devel] [PATCH 1/2] makefile: merge GENERATED_HEADERS & GENERATED_SOURCES variables Daniel P. Berrange
2017-03-01 2:04 ` Eric Blake
2017-02-28 12:29 ` [Qemu-devel] [PATCH 2/2] makefile: generate trace-events-all upfront Daniel P. Berrange
2017-02-28 12:47 ` [Qemu-devel] [PATCH 0/2] Fix stale 'trace-events-all' file in build dir Fam Zheng
2017-03-01 12:19 ` Stefan Hajnoczi
2017-03-01 12:20 ` Daniel P. Berrange [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170301122036.GB10160@redhat.com \
--to=berrange@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).