From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41916) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1clBCK-00039o-RU for qemu-devel@nongnu.org; Tue, 07 Mar 2017 04:14:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1clBCG-0004US-DT for qemu-devel@nongnu.org; Tue, 07 Mar 2017 04:14:24 -0500 Date: Tue, 7 Mar 2017 17:14:10 +0800 From: Fam Zheng Message-ID: <20170307091410.GE29283@lemon.lan> References: <20170225193155.447462-1-vsementsov@virtuozzo.com> <20170225193155.447462-2-vsementsov@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170225193155.447462-2-vsementsov@virtuozzo.com> Subject: Re: [Qemu-devel] [PATCH 1/4] iotests: add migration corner cases test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Sementsov-Ogievskiy Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, pbonzini@redhat.com, armbru@redhat.com, eblake@redhat.com, stefanha@redhat.com, amit.shah@redhat.com, quintela@redhat.com, mreitz@redhat.com, kwolf@redhat.com, peter.maydell@linaro.org, dgilbert@redhat.com, den@openvz.org, jsnow@redhat.com, lirans@il.ibm.com On Sat, 02/25 22:31, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > tests/qemu-iotests/175 | 71 ++++++++++++++++++++++++++++++++++++++++++++++ > tests/qemu-iotests/175.out | 5 ++++ > tests/qemu-iotests/group | 1 + > 3 files changed, 77 insertions(+) > create mode 100644 tests/qemu-iotests/175 > create mode 100644 tests/qemu-iotests/175.out > > diff --git a/tests/qemu-iotests/175 b/tests/qemu-iotests/175 > new file mode 100644 > index 0000000000..ef86c70db5 > --- /dev/null > +++ b/tests/qemu-iotests/175 > @@ -0,0 +1,71 @@ > +#!/usr/bin/env python > +# > +# Test migration corner-cases > +# > +# Copyright (C) Vladimir Sementsov-Ogievskiy 2017 > +# > +# This program is free software; you can redistribute it and/or modify > +# it under the terms of the GNU General Public License as published by > +# the Free Software Foundation; either version 2 of the License, or > +# (at your option) any later version. > +# > +# This program is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program. If not, see . > +# > + > +import os > +import iotests > +import time > +from iotests import qemu_img > + > +disk = os.path.join(iotests.test_dir, 'disk') > + > +class TestMigrationCornerCases(iotests.QMPTestCase): > + def setUp(self): > + qemu_img('create', '-f', iotests.imgfmt, disk, '10M') > + self.vm = iotests.VM().add_drive(disk) > + self.vm.launch() > + > + def tearDown(self): > + self.vm.shutdown() > + os.remove(disk) > + > + def test_migrate_reset_cont_write(self): > + result = self.vm.qmp('migrate', uri='exec:cat>/dev/null') > + self.assert_qmp(result, 'return', {}) > + time.sleep(4) Should you query the migration status instead of blink sleep? > + > + result = self.vm.qmp('human-monitor-command', > + command_line='system_reset') > + self.assert_qmp(result, 'return', '') > + > + result = self.vm.qmp('cont') > + self.assert_qmp(result, 'return', {}) > + > + result = self.vm.qmp('human-monitor-command', > + command_line='qemu-io drive0 "write 0 512"') > + self.assert_qmp(result, 'return', '') > + > + def test_migrate_savevm(self): > + result = self.vm.qmp('migrate', uri='exec:cat>/dev/null') > + self.assert_qmp(result, 'return', {}) > + time.sleep(4) Ditto. > + > + result = self.vm.qmp('human-monitor-command', command_line='savevm') > + self.assert_qmp(result, 'return', '') > + > + def test_savevm_set_speed_savevm(self): > + for i in range(10): > + result = self.vm.qmp('human-monitor-command', command_line='savevm') > + self.assert_qmp(result, 'return', '') > + > + result = self.vm.qmp('migrate_set_speed', value=9223372036853727232) > + self.assert_qmp(result, 'return', {}) > + > +if __name__ == '__main__': > + iotests.main() > diff --git a/tests/qemu-iotests/175.out b/tests/qemu-iotests/175.out > new file mode 100644 > index 0000000000..8d7e996700 > --- /dev/null > +++ b/tests/qemu-iotests/175.out > @@ -0,0 +1,5 @@ > +... > +---------------------------------------------------------------------- > +Ran 3 tests > + > +OK > diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group > index 985b9a6a36..1f4bf03185 100644 > --- a/tests/qemu-iotests/group > +++ b/tests/qemu-iotests/group > @@ -167,3 +167,4 @@ > 172 auto > 173 rw auto > 174 auto > +175 auto quick Not sure it still qualifies as "quick" given the two "time.sleep(4)", but more importantly I wonder if the sleep should be improved. Fam