From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58017) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1clBwr-0006dP-F7 for qemu-devel@nongnu.org; Tue, 07 Mar 2017 05:02:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1clBwh-0006Ts-El for qemu-devel@nongnu.org; Tue, 07 Mar 2017 05:02:25 -0500 Date: Tue, 7 Mar 2017 11:02:04 +0100 From: Kevin Wolf Message-ID: <20170307100204.GC5871@noname.str.redhat.com> References: <20170225193155.447462-1-vsementsov@virtuozzo.com> <20170225193155.447462-3-vsementsov@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170225193155.447462-3-vsementsov@virtuozzo.com> Subject: Re: [Qemu-devel] [PATCH 2/4] qmp-cont: invalidate on RUN_STATE_PRELAUNCH List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Sementsov-Ogievskiy Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, pbonzini@redhat.com, armbru@redhat.com, eblake@redhat.com, famz@redhat.com, stefanha@redhat.com, amit.shah@redhat.com, quintela@redhat.com, mreitz@redhat.com, peter.maydell@linaro.org, dgilbert@redhat.com, den@openvz.org, jsnow@redhat.com, lirans@il.ibm.com Am 25.02.2017 um 20:31 hat Vladimir Sementsov-Ogievskiy geschrieben: > We must invalidate on RUN_STATE_PRELAUNCH too, as it is available > through qmp_system_reset from RUN_STATE_POSTMIGRATE. Otherwise, we will > come to > > qemu-kvm: block/io.c:1406: bdrv_co_do_pwritev: > Assertion `!(bs->open_flags & 0x0800)' failed. > > on the first write after vm start. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Wouldn't it make more sense to invalidate in qmp_system_reset() where the migration states are left? Or maybe BDRV_O_INACTIVE could even be tied directly to runstates? Not sure how realistic this one is, but if we start adding invalidate_cache calls all over the place, maybe that's a sign that we need to look for a more central place. Kevin > qmp.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/qmp.c b/qmp.c > index dfaabac1a6..e61795d033 100644 > --- a/qmp.c > +++ b/qmp.c > @@ -198,7 +198,8 @@ void qmp_cont(Error **errp) > /* Continuing after completed migration. Images have been inactivated to > * allow the destination to take control. Need to get control back now. */ > if (runstate_check(RUN_STATE_FINISH_MIGRATE) || > - runstate_check(RUN_STATE_POSTMIGRATE)) > + runstate_check(RUN_STATE_POSTMIGRATE) || > + runstate_check(RUN_STATE_PRELAUNCH)) > { > bdrv_invalidate_cache_all(&local_err); > if (local_err) { > -- > 2.11.1 >