qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org,
	pbonzini@redhat.com, armbru@redhat.com, eblake@redhat.com,
	famz@redhat.com, stefanha@redhat.com, quintela@redhat.com,
	mreitz@redhat.com, kwolf@redhat.com, peter.maydell@linaro.org,
	den@openvz.org, jsnow@redhat.com, lirans@il.ibm.com
Subject: Re: [Qemu-devel] [PATCH 1/4] iotests: add migration corner cases test
Date: Tue, 7 Mar 2017 11:23:17 +0000	[thread overview]
Message-ID: <20170307112316.GE2869@work-vm> (raw)
In-Reply-To: <20170225193155.447462-2-vsementsov@virtuozzo.com>

* Vladimir Sementsov-Ogievskiy (vsementsov@virtuozzo.com) wrote:
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

If I understand this correctly, these are tests that currently fail and
are fixed by the following patches;  in which case it needs reordering
to keep stuff bisectable.

Dave

> ---
>  tests/qemu-iotests/175     | 71 ++++++++++++++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/175.out |  5 ++++
>  tests/qemu-iotests/group   |  1 +
>  3 files changed, 77 insertions(+)
>  create mode 100644 tests/qemu-iotests/175
>  create mode 100644 tests/qemu-iotests/175.out
> 
> diff --git a/tests/qemu-iotests/175 b/tests/qemu-iotests/175
> new file mode 100644
> index 0000000000..ef86c70db5
> --- /dev/null
> +++ b/tests/qemu-iotests/175
> @@ -0,0 +1,71 @@
> +#!/usr/bin/env python
> +#
> +# Test migration corner-cases
> +#
> +# Copyright (C) Vladimir Sementsov-Ogievskiy 2017
> +#
> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation; either version 2 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.
> +#
> +
> +import os
> +import iotests
> +import time
> +from iotests import qemu_img
> +
> +disk = os.path.join(iotests.test_dir, 'disk')
> +
> +class TestMigrationCornerCases(iotests.QMPTestCase):
> +    def setUp(self):
> +        qemu_img('create', '-f', iotests.imgfmt, disk, '10M')
> +        self.vm = iotests.VM().add_drive(disk)
> +        self.vm.launch()
> +
> +    def tearDown(self):
> +        self.vm.shutdown()
> +        os.remove(disk)
> +
> +    def test_migrate_reset_cont_write(self):
> +        result = self.vm.qmp('migrate', uri='exec:cat>/dev/null')
> +        self.assert_qmp(result, 'return', {})
> +        time.sleep(4)
> +
> +        result = self.vm.qmp('human-monitor-command',
> +                             command_line='system_reset')
> +        self.assert_qmp(result, 'return', '')
> +
> +        result = self.vm.qmp('cont')
> +        self.assert_qmp(result, 'return', {})
> +
> +        result = self.vm.qmp('human-monitor-command',
> +                             command_line='qemu-io drive0 "write 0 512"')
> +        self.assert_qmp(result, 'return', '')
> +
> +    def test_migrate_savevm(self):
> +        result = self.vm.qmp('migrate', uri='exec:cat>/dev/null')
> +        self.assert_qmp(result, 'return', {})
> +        time.sleep(4)
> +
> +        result = self.vm.qmp('human-monitor-command', command_line='savevm')
> +        self.assert_qmp(result, 'return', '')
> +
> +    def test_savevm_set_speed_savevm(self):
> +        for i in range(10):
> +            result = self.vm.qmp('human-monitor-command', command_line='savevm')
> +            self.assert_qmp(result, 'return', '')
> +
> +            result = self.vm.qmp('migrate_set_speed', value=9223372036853727232)
> +            self.assert_qmp(result, 'return', {})
> +
> +if __name__ == '__main__':
> +    iotests.main()
> diff --git a/tests/qemu-iotests/175.out b/tests/qemu-iotests/175.out
> new file mode 100644
> index 0000000000..8d7e996700
> --- /dev/null
> +++ b/tests/qemu-iotests/175.out
> @@ -0,0 +1,5 @@
> +...
> +----------------------------------------------------------------------
> +Ran 3 tests
> +
> +OK
> diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group
> index 985b9a6a36..1f4bf03185 100644
> --- a/tests/qemu-iotests/group
> +++ b/tests/qemu-iotests/group
> @@ -167,3 +167,4 @@
>  172 auto
>  173 rw auto
>  174 auto
> +175 auto quick
> -- 
> 2.11.1
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK

  parent reply	other threads:[~2017-03-07 11:23 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-25 19:31 [Qemu-devel] [PATCH 0/4] some migration bugs Vladimir Sementsov-Ogievskiy
2017-02-25 19:31 ` [Qemu-devel] [PATCH 1/4] iotests: add migration corner cases test Vladimir Sementsov-Ogievskiy
2017-03-07  9:14   ` Fam Zheng
2017-03-07 11:23   ` Dr. David Alan Gilbert [this message]
2017-02-25 19:31 ` [Qemu-devel] [PATCH 2/4] qmp-cont: invalidate on RUN_STATE_PRELAUNCH Vladimir Sementsov-Ogievskiy
2017-03-07  9:19   ` Fam Zheng
2017-03-07 10:02   ` Kevin Wolf
2017-03-07 10:11     ` Vladimir Sementsov-Ogievskiy
2017-03-07 10:22       ` Kevin Wolf
2017-04-26 12:22       ` [Qemu-devel] [Qemu-block] " Kashyap Chamarthy
2017-04-26 13:43         ` Vladimir Sementsov-Ogievskiy
2017-02-25 19:31 ` [Qemu-devel] [PATCH 3/4] savevm: fix savevm after migration Vladimir Sementsov-Ogievskiy
2017-02-27  9:42   ` Denis V. Lunev
2017-03-07  9:53   ` Kevin Wolf
2017-03-07  9:59     ` Vladimir Sementsov-Ogievskiy
2017-03-07 11:01       ` Kevin Wolf
2017-03-07 11:20         ` Dr. David Alan Gilbert
2017-03-28 10:55     ` Dr. David Alan Gilbert
2017-03-28 11:09       ` Kevin Wolf
2017-03-28 11:13         ` Dr. David Alan Gilbert
2017-03-28 12:09           ` Kevin Wolf
2017-03-28 13:16             ` Vladimir Sementsov-Ogievskiy
2017-03-28 14:15               ` Paolo Bonzini
2017-03-29 15:29                 ` Dr. David Alan Gilbert
2017-03-29 15:53                   ` Paolo Bonzini
2017-04-25 14:22                     ` [Qemu-devel] ping " Vladimir Sementsov-Ogievskiy
2017-03-28 11:18       ` [Qemu-devel] " Denis V. Lunev
2017-02-25 19:31 ` [Qemu-devel] [PATCH 4/4] migration: fix use-after-free of to_dst_file Vladimir Sementsov-Ogievskiy
2017-02-27 10:44   ` Dr. David Alan Gilbert
2017-02-28  9:59   ` Dr. David Alan Gilbert
2017-03-06 14:23 ` [Qemu-devel] [PATCH 0/4] some migration bugs Denis V. Lunev
2017-03-20  9:44   ` [Qemu-devel] ping " Vladimir Sementsov-Ogievskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170307112316.GE2869@work-vm \
    --to=dgilbert@redhat.com \
    --cc=armbru@redhat.com \
    --cc=den@openvz.org \
    --cc=eblake@redhat.com \
    --cc=famz@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=lirans@il.ibm.com \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).