qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org
Cc: quintela@redhat.com, marcel@redhat.com, pbonzini@redhat.com,
	imammedo@redhat.com, lvivier@redhat.com
Subject: [Qemu-devel] RAMBlock's named ""
Date: Tue, 7 Mar 2017 19:46:56 +0000	[thread overview]
Message-ID: <20170307194617.GJ2869@work-vm> (raw)

We seem to have a couple of weird cases where we end up with
RAMBlocks with no name;  I think they'll badly confuse
the migration code, but I don't quite understand how they're
happening.

1) device_del e1000e
2) -object memory-backend-file  without wiring it up

I added some debug into migration/ram.c ram_save_setup to
dump the names it was seeing in it's FOREACH.

1)
  (from https://bugzilla.redhat.com/show_bug.cgi?id=1425273)
  The simplest reproducer of this is:

./qemu-system-x86_64 -nographic  -device e1000e,id=foo -m 1G -M pc,accel=kvm my.img

  with a Linux image and after it's booted do a device_del foo

  migration at that point sees an empty RAMBlock that was the ROM
  associated with the device.  This doesn't happen on an e1000 device,
  so I've not figured out what the difference is.

  This gives a : Unknown ramblock "", cannot accept migration
  on the destination (correctly).

  (This happens on 2.7.0 as well, so it's nothing new)

2)
  ./qemu-system-x86_64 -nographic -object memory-backend-file,id=mem,size=512M,mem-path=/tmp

  Note I've not wired that memory to a NUMA node or a DIMM or anything, so
  it's just hanging around.
  Again that RAMBlock does exist and shows up in the migration code,
  I think it'll try and migrate it.

The real fun is that there doesn't seem to be anything that stops
two blocks having the same name!

Dave

--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK

             reply	other threads:[~2017-03-07 19:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-07 19:46 Dr. David Alan Gilbert [this message]
2017-03-08  7:49 ` [Qemu-devel] RAMBlock's named "" Peter Maydell
2017-03-08  9:55   ` Dr. David Alan Gilbert
2017-03-08 10:31 ` Igor Mammedov
2017-03-08 10:45   ` Dr. David Alan Gilbert
2017-03-08 11:09     ` Juan Quintela
2017-03-09 11:56 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170307194617.GJ2869@work-vm \
    --to=dgilbert@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=marcel@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).