From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, kwolf@redhat.com
Subject: [Qemu-devel] [PATCH for-2.9 0/3] Fix bdrv_is_allocated usage bugs
Date: Wed, 8 Mar 2017 15:34:26 -0600 [thread overview]
Message-ID: <20170308213429.29244-1-eblake@redhat.com> (raw)
bdrv_is_allocated() returns tri-state, not just bool, although
there were several callers using it as a bool. Fix them to
either propagate the error or to document why treatment of
failure like allocation is okay.
[Found during a larger effort to convert bdrv_get_block_status
to be byte-based for 2.10]
Eric Blake (3):
backup: React to bdrv_is_allocated() errors
vvfat: React to bdrv_is_allocated() errors
migration: Document handling of bdrv_is_allocated() errors
block/backup.c | 14 ++++++++++----
block/vvfat.c | 22 +++++++++++++++++++---
migration/block.c | 2 ++
3 files changed, 31 insertions(+), 7 deletions(-)
--
2.9.3
next reply other threads:[~2017-03-08 21:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 21:34 Eric Blake [this message]
2017-03-08 21:34 ` [Qemu-devel] [PATCH 1/3] backup: React to bdrv_is_allocated() errors Eric Blake
2017-03-08 21:34 ` [Qemu-devel] [PATCH 2/3] vvfat: " Eric Blake
2017-03-08 21:34 ` [Qemu-devel] [PATCH 3/3] migration: Document handling of " Eric Blake
2017-03-09 15:39 ` [Qemu-devel] [PATCH for-2.9 0/3] Fix bdrv_is_allocated usage bugs Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170308213429.29244-1-eblake@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).