* [Qemu-devel] [PATCH] target/ppc: Fix wrong number of UAMR register
@ 2017-03-08 19:58 Thomas Huth
2017-03-09 1:34 ` David Gibson
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Huth @ 2017-03-08 19:58 UTC (permalink / raw)
To: qemu-ppc, qemu-devel, David Gibson; +Cc: Alexander Graf
The SPR UAMR has the number 13, and not 12. (Fortunately it seems like
Linux is not using this register yet - only the privileged version with
number 29 ... that's why nobody noticed this problem yet)
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
target/ppc/cpu.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h
index 7c4a1f5..5ee33b3 100644
--- a/target/ppc/cpu.h
+++ b/target/ppc/cpu.h
@@ -1408,7 +1408,7 @@ int ppc_compat_max_threads(PowerPCCPU *cpu);
#define SPR_601_UDECR (0x006)
#define SPR_LR (0x008)
#define SPR_CTR (0x009)
-#define SPR_UAMR (0x00C)
+#define SPR_UAMR (0x00D)
#define SPR_DSCR (0x011)
#define SPR_DSISR (0x012)
#define SPR_DAR (0x013) /* DAE for PowerPC 601 */
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] target/ppc: Fix wrong number of UAMR register
2017-03-08 19:58 [Qemu-devel] [PATCH] target/ppc: Fix wrong number of UAMR register Thomas Huth
@ 2017-03-09 1:34 ` David Gibson
0 siblings, 0 replies; 2+ messages in thread
From: David Gibson @ 2017-03-09 1:34 UTC (permalink / raw)
To: Thomas Huth; +Cc: qemu-ppc, qemu-devel, Alexander Graf
[-- Attachment #1: Type: text/plain, Size: 1216 bytes --]
On Wed, Mar 08, 2017 at 08:58:43PM +0100, Thomas Huth wrote:
> The SPR UAMR has the number 13, and not 12. (Fortunately it seems like
> Linux is not using this register yet - only the privileged version with
> number 29 ... that's why nobody noticed this problem yet)
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> target/ppc/cpu.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to ppc-for-2.9, thanks.
>
> diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h
> index 7c4a1f5..5ee33b3 100644
> --- a/target/ppc/cpu.h
> +++ b/target/ppc/cpu.h
> @@ -1408,7 +1408,7 @@ int ppc_compat_max_threads(PowerPCCPU *cpu);
> #define SPR_601_UDECR (0x006)
> #define SPR_LR (0x008)
> #define SPR_CTR (0x009)
> -#define SPR_UAMR (0x00C)
> +#define SPR_UAMR (0x00D)
> #define SPR_DSCR (0x011)
> #define SPR_DSISR (0x012)
> #define SPR_DAR (0x013) /* DAE for PowerPC 601 */
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-09 3:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-08 19:58 [Qemu-devel] [PATCH] target/ppc: Fix wrong number of UAMR register Thomas Huth
2017-03-09 1:34 ` David Gibson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).