qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: peter.maydell@linaro.org
Cc: qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Peter Crosthwaite" <crosthwaite.peter@gmail.com>,
	"Richard Henderson" <rth@twiddle.net>
Subject: [Qemu-devel] [PULL 03/11] cpus.c: add additional error_report when !TARGET_SUPPORT_MTTCG
Date: Thu,  9 Mar 2017 11:17:06 +0000	[thread overview]
Message-ID: <20170309111714.20394-4-alex.bennee@linaro.org> (raw)
In-Reply-To: <20170309111714.20394-1-alex.bennee@linaro.org>

While we may fail the memory ordering check later that can be
confusing. So in cases where TARGET_SUPPORT_MTTCG has yet to be
defined we should say so specifically.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <rth@twiddle.net>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 cpus.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/cpus.c b/cpus.c
index 6a817fec13..69e21858b8 100644
--- a/cpus.c
+++ b/cpus.c
@@ -202,6 +202,10 @@ void qemu_tcg_configure(QemuOpts *opts, Error **errp)
             } else if (use_icount) {
                 error_setg(errp, "No MTTCG when icount is enabled");
             } else {
+#ifndef TARGET_SUPPORT_MTTCG
+                error_report("Guest not yet converted to MTTCG - "
+                             "you may get unexpected results");
+#endif
                 if (!check_tcg_memory_orders_compatible()) {
                     error_report("Guest expects a stronger memory ordering "
                                  "than the host provides");
-- 
2.11.0

  parent reply	other threads:[~2017-03-09 11:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-09 11:17 [Qemu-devel] [PULL 00/11] MTTCG Fix-ups for 2.9 Alex Bennée
2017-03-09 11:17 ` [Qemu-devel] [PULL 01/11] vl/cpus: be smarter with icount and MTTCG Alex Bennée
2017-03-09 11:17 ` [Qemu-devel] [PULL 02/11] target/i386/cpu.h: declare TCG_GUEST_DEFAULT_MO Alex Bennée
2017-03-09 11:17 ` Alex Bennée [this message]
2017-03-09 11:17 ` [Qemu-devel] [PULL 04/11] sparc/sparc64: grab BQL before calling cpu_check_irqs Alex Bennée
2017-03-09 11:17 ` [Qemu-devel] [PULL 05/11] s390x/misc_helper.c: wrap IO instructions in BQL Alex Bennée
2017-03-09 11:17 ` [Qemu-devel] [PULL 06/11] target/xtensa: hold BQL for interrupt processing Alex Bennée
2017-03-09 11:17 ` [Qemu-devel] [PULL 07/11] translate-all: exit cpu_restore_state early if translating Alex Bennée
2017-03-09 11:17 ` [Qemu-devel] [PULL 08/11] target/mips: hold BQL for timer interrupts Alex Bennée
2017-03-09 11:17 ` [Qemu-devel] [PULL 09/11] target-i386: defer VMEXIT to do_interrupt Alex Bennée
2017-03-09 11:17 ` [Qemu-devel] [PULL 10/11] target/arm/helper: make it clear the EC field is also in hex Alex Bennée
2017-03-09 11:17 ` [Qemu-devel] [PULL 11/11] hw/intc/arm_gic: modernise the DPRINTF Alex Bennée
2017-03-13 11:25 ` [Qemu-devel] [PULL 00/11] MTTCG Fix-ups for 2.9 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170309111714.20394-4-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=crosthwaite.peter@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).