From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [PATCH v2] memory_region: Fix name comments
Date: Thu, 9 Mar 2017 16:13:52 +0000 [thread overview]
Message-ID: <20170309161352.GI2480@work-vm> (raw)
In-Reply-To: <fa186054-0b8c-924f-b30b-34ed92a83337@redhat.com>
* Paolo Bonzini (pbonzini@redhat.com) wrote:
>
>
> On 09/03/2017 16:27, Dr. David Alan Gilbert (git) wrote:
> > + * @name: Region name, becomes part of RAMBlock name used in migration stream
> > + * must be unique within any device
> > * @size: size of the region; any subregions beyond this size will be clipped
> > */
> > void memory_region_init(MemoryRegion *mr,
> > struct Object *owner,
> > const char *name,
> > uint64_t size);
>
> This one should not be necessary I guess?
Why? It's not static so something else could be calling it for
any use.
Dave
> Paolo
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2017-03-09 16:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-09 15:27 [Qemu-devel] [PATCH v2] memory_region: Fix name comments Dr. David Alan Gilbert (git)
2017-03-09 16:07 ` Paolo Bonzini
2017-03-09 16:13 ` Dr. David Alan Gilbert [this message]
2017-03-09 16:26 ` Paolo Bonzini
2017-03-09 16:38 ` Dr. David Alan Gilbert
2017-03-10 8:48 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170309161352.GI2480@work-vm \
--to=dgilbert@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).