From: Stefan Hajnoczi <stefanha@gmail.com>
To: Alberto Garcia <berto@igalia.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
Nir Soffer <nsoffer@redhat.com>,
Maor Lipchuk <mlipchuk@redhat.com>, John Snow <jsnow@redhat.com>
Subject: Re: [Qemu-devel] [RFC 2/4] raw-format: add bdrv_max_size() support
Date: Fri, 10 Mar 2017 12:33:44 +0800 [thread overview]
Message-ID: <20170310043344.GD4589@stefanha-x1.localdomain> (raw)
In-Reply-To: <w51k2812x8i.fsf@maestria.local.igalia.com>
[-- Attachment #1: Type: text/plain, Size: 662 bytes --]
On Tue, Mar 07, 2017 at 11:32:29AM +0100, Alberto Garcia wrote:
> On Fri 03 Mar 2017 02:51:48 PM CET, Stefan Hajnoczi wrote:
>
> > +static uint64_t raw_max_size(QemuOpts *opts, BlockDriverState *in_bs,
> > + Error **errp)
> > +{
> > + if (in_bs) {
> > + int64_t size = bdrv_nb_sectors(in_bs);
> > + if (size < 0) {
> > + error_setg_errno(errp, -size, "Unable to get image size");
> > + return 0;
> > + }
> > + return (uint64_t)size * BDRV_SECTOR_SIZE;
> > + }
>
> Why not use bdrv_getlength() directly? It gives you the size in bytes.
Good idea. Will fix.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2017-03-10 4:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-03 13:51 [Qemu-devel] [RFC 0/4] qemu-img: add max-size subcommand Stefan Hajnoczi
2017-03-03 13:51 ` [Qemu-devel] [RFC 1/4] block: add bdrv_max_size() API Stefan Hajnoczi
2017-03-07 10:27 ` Alberto Garcia
2017-03-03 13:51 ` [Qemu-devel] [RFC 2/4] raw-format: add bdrv_max_size() support Stefan Hajnoczi
2017-03-07 10:32 ` Alberto Garcia
2017-03-10 4:33 ` Stefan Hajnoczi [this message]
2017-03-03 13:51 ` [Qemu-devel] [RFC 3/4] qemu-img: add max-size subcommand Stefan Hajnoczi
2017-03-03 21:56 ` Nir Soffer
2017-03-10 4:42 ` Stefan Hajnoczi
2017-03-03 13:51 ` [Qemu-devel] [RFC 4/4] iotests: add test 178 for qemu-img max-size Stefan Hajnoczi
2017-03-03 20:48 ` [Qemu-devel] [RFC 0/4] qemu-img: add max-size subcommand John Snow
2017-03-03 21:38 ` Nir Soffer
2017-03-03 22:02 ` John Snow
2017-03-03 22:15 ` Nir Soffer
2017-03-04 0:14 ` Nir Soffer
2017-03-10 7:58 ` Stefan Hajnoczi
2017-03-07 10:36 ` Daniel P. Berrange
2017-03-07 12:11 ` Alberto Garcia
2017-03-07 12:25 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170310043344.GD4589@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=berto@igalia.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mlipchuk@redhat.com \
--cc=nsoffer@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).