From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57391) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cmGIz-0004Ec-Jw for qemu-devel@nongnu.org; Fri, 10 Mar 2017 03:53:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cmGIw-0002Eq-Ds for qemu-devel@nongnu.org; Fri, 10 Mar 2017 03:53:45 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47232) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cmGIw-0002Ej-88 for qemu-devel@nongnu.org; Fri, 10 Mar 2017 03:53:42 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7548C3A76AB for ; Fri, 10 Mar 2017 08:53:41 +0000 (UTC) From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Date: Fri, 10 Mar 2017 12:53:31 +0400 Message-Id: <20170310085331.17916-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH] scripts/dump-guest-memory.py: fix int128_get64 on recent gcc List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: lersek@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= The Int128 is no longer a struct, reaching a python exception: Python Exception Attempt to extract a component of a = value that is not a (null).: Replace struct access with a cast to uint64 instead. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=3D1427466 Signed-off-by: Marc-Andr=C3=A9 Lureau --- scripts/dump-guest-memory.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/scripts/dump-guest-memory.py b/scripts/dump-guest-memory.py index 9956fc036c..bbe1c14ba2 100644 --- a/scripts/dump-guest-memory.py +++ b/scripts/dump-guest-memory.py @@ -314,8 +314,10 @@ def get_arch_phdr(endianness, elfclass): def int128_get64(val): """Returns low 64bit part of Int128 struct.""" =20 - assert val["hi"] =3D=3D 0 - return val["lo"] + u64t =3D gdb.lookup_type('uint64_t').array(2) + u64 =3D val.cast(u64t) + assert u64[1] =3D=3D 0 + return u64[0] =20 =20 def qlist_foreach(head, field_str): --=20 2.12.0.rc2.3.gc93709801