From: Richard Henderson <rth@twiddle.net>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, riku.voipio@iki.fi, deller@gmx.de
Subject: [Qemu-devel] [PATCH 3/3] target/hppa: Fix cpu_clone_regs
Date: Sat, 11 Mar 2017 13:42:32 +1000 [thread overview]
Message-ID: <20170311034232.14213-4-rth@twiddle.net> (raw)
In-Reply-To: <20170311034232.14213-1-rth@twiddle.net>
By failing to return from the syscall in the child, the child
issues another clone syscall and hilarity ensues.
Signed-off-by: Richard Henderson <rth@twiddle.net>
---
linux-user/hppa/target_cpu.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/linux-user/hppa/target_cpu.h b/linux-user/hppa/target_cpu.h
index 1a5ceca..e50522e 100644
--- a/linux-user/hppa/target_cpu.h
+++ b/linux-user/hppa/target_cpu.h
@@ -24,7 +24,11 @@ static inline void cpu_clone_regs(CPUHPPAState *env, target_ulong newsp)
if (newsp) {
env->gr[30] = newsp;
}
+ /* Indicate child in return value. */
env->gr[28] = 0;
+ /* Return from the syscall. */
+ env->iaoq_f = env->gr[31];
+ env->iaoq_b = env->gr[31] + 4;
}
static inline void cpu_set_tls(CPUHPPAState *env, target_ulong newtls)
--
2.9.3
prev parent reply other threads:[~2017-03-11 3:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-11 3:42 [Qemu-devel] [PATCH 0/3] Fixes for hppa-linux-user Richard Henderson
2017-03-11 3:42 ` [Qemu-devel] [PATCH 1/3] linux-user: Restrict usage of sa_restorer Richard Henderson
2017-03-11 18:28 ` Laurent Vivier
2017-03-11 21:02 ` Richard Henderson
2017-03-11 22:39 ` Richard Henderson
2017-03-11 3:42 ` [Qemu-devel] [PATCH 2/3] linux-user: Fix TARGET_SA_* defines for HPPA Richard Henderson
2017-03-11 9:14 ` Helge Deller
2017-03-11 14:14 ` Laurent Vivier
2017-03-11 3:42 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170311034232.14213-4-rth@twiddle.net \
--to=rth@twiddle.net \
--cc=deller@gmx.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).