From: Kevin Wolf <kwolf@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Max Reitz <mreitz@redhat.com>,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] file-posix: Don't leak fd in hdev_get_max_segments
Date: Tue, 14 Mar 2017 16:50:46 +0100 [thread overview]
Message-ID: <20170314155046.GL3952@noname.str.redhat.com> (raw)
In-Reply-To: <20170314154315.17869-1-famz@redhat.com>
Am 14.03.2017 um 16:43 hat Fam Zheng geschrieben:
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> block/file-posix.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/block/file-posix.c b/block/file-posix.c
> index c4c0663..e6170f4 100644
> --- a/block/file-posix.c
> +++ b/block/file-posix.c
> @@ -703,6 +703,7 @@ static int hdev_get_max_segments(const struct stat *st)
> }
>
> out:
> + close(fd);
Should we make this conditional on fd != -1?
> g_free(sysfspath);
> return ret;
> #else
Kevin
next prev parent reply other threads:[~2017-03-14 15:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-14 15:43 [Qemu-devel] [PATCH] file-posix: Don't leak fd in hdev_get_max_segments Fam Zheng
2017-03-14 15:50 ` Kevin Wolf [this message]
2017-03-14 16:11 ` Fam Zheng
2017-03-14 16:11 ` Eric Blake
2017-03-14 16:14 ` Eric Blake
2017-03-14 16:16 ` Eric Blake
2017-03-14 16:16 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170314155046.GL3952@noname.str.redhat.com \
--to=kwolf@redhat.com \
--cc=famz@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).