From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Nir Soffer <nsoffer@redhat.com>, Kevin Wolf <kwolf@redhat.com>,
Maor Lipchuk <mlipchuk@redhat.com>,
"Daniel P. Berrange" <berrange@redhat.com>,
Eric Blake <eblake@redhat.com>, Alberto Garcia <berto@igalia.com>,
John Snow <jsnow@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [RFC v2 5/8] qcow2: add bdrv_measure() support
Date: Wed, 15 Mar 2017 17:29:37 +0800 [thread overview]
Message-ID: <20170315092940.1367-6-stefanha@redhat.com> (raw)
In-Reply-To: <20170315092940.1367-1-stefanha@redhat.com>
Use qcow2_calc_prealloc_size() to get the required file size.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
TODO:
* Query block status and only count allocated clusters if in_bs != NULL
* Exclude backing file clusters if in_bs != NULL and -o backing_file=
is given
---
block/qcow2.c | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 53 insertions(+)
diff --git a/block/qcow2.c b/block/qcow2.c
index 19be468..a4caf97 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -2940,6 +2940,58 @@ static coroutine_fn int qcow2_co_flush_to_os(BlockDriverState *bs)
return 0;
}
+static void qcow2_measure(QemuOpts *opts, BlockDriverState *in_bs,
+ BlockMeasureInfo *info, Error **errp)
+{
+ Error *local_err = NULL;
+ uint64_t allocated_bytes = 0;
+ uint64_t prealloc_size;
+ uint64_t size;
+ uint64_t refcount_bits;
+ size_t cluster_size;
+ int version;
+
+ size = ROUND_UP(qemu_opt_get_size_del(opts, BLOCK_OPT_SIZE, 0),
+ BDRV_SECTOR_SIZE);
+
+ cluster_size = qcow2_opt_get_cluster_size_del(opts, &local_err);
+ if (local_err) {
+ goto err;
+ }
+
+ version = qcow2_opt_get_version_del(opts, &local_err);
+ if (local_err) {
+ goto err;
+ }
+
+ refcount_bits = qcow2_opt_get_refcount_bits_del(opts, version, &local_err);
+ if (local_err) {
+ goto err;
+ }
+
+ if (in_bs) {
+ int64_t ssize = bdrv_getlength(in_bs);
+ if (ssize < 0) {
+ error_setg_errno(errp, -ssize, "Unable to get image size");
+ return;
+ }
+
+ size = ssize;
+
+ /* TODO How many clusters are allocated modulo backing file in opts? */
+ }
+
+ prealloc_size = qcow2_calc_prealloc_size(size, cluster_size,
+ ctz32(refcount_bits));
+ info->required_bytes = prealloc_size - (align_offset(size, cluster_size) -
+ allocated_bytes);
+ info->fully_allocated_bytes = prealloc_size;
+ return;
+
+err:
+ error_propagate(errp, local_err);
+}
+
static int qcow2_get_info(BlockDriverState *bs, BlockDriverInfo *bdi)
{
BDRVQcow2State *s = bs->opaque;
@@ -3487,6 +3539,7 @@ BlockDriver bdrv_qcow2 = {
.bdrv_snapshot_delete = qcow2_snapshot_delete,
.bdrv_snapshot_list = qcow2_snapshot_list,
.bdrv_snapshot_load_tmp = qcow2_snapshot_load_tmp,
+ .bdrv_measure = qcow2_measure,
.bdrv_get_info = qcow2_get_info,
.bdrv_get_specific_info = qcow2_get_specific_info,
--
2.9.3
next prev parent reply other threads:[~2017-03-15 9:30 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-15 9:29 [Qemu-devel] [RFC v2 0/8] qemu-img: add measure sub-command Stefan Hajnoczi
2017-03-15 9:29 ` [Qemu-devel] [RFC v2 1/8] block: add bdrv_measure() API Stefan Hajnoczi
2017-03-16 1:01 ` Max Reitz
2017-03-16 3:38 ` Stefan Hajnoczi
2017-03-16 4:02 ` Max Reitz
2017-03-18 0:51 ` Nir Soffer
2017-03-20 15:37 ` Stefan Hajnoczi
2017-03-18 1:28 ` Nir Soffer
2017-03-20 15:34 ` Stefan Hajnoczi
2017-03-15 9:29 ` [Qemu-devel] [RFC v2 2/8] raw-format: add bdrv_measure() support Stefan Hajnoczi
2017-03-18 1:11 ` Nir Soffer
2017-03-15 9:29 ` [Qemu-devel] [RFC v2 3/8] qcow2: extract preallocation calculation function Stefan Hajnoczi
2017-03-16 1:18 ` Max Reitz
2017-03-16 3:40 ` Stefan Hajnoczi
2017-03-15 9:29 ` [Qemu-devel] [RFC v2 4/8] qcow2: extract image creation option parsing Stefan Hajnoczi
2017-03-18 20:14 ` Nir Soffer
2017-03-20 15:40 ` Stefan Hajnoczi
2017-03-15 9:29 ` Stefan Hajnoczi [this message]
2017-03-16 1:57 ` [Qemu-devel] [RFC v2 5/8] qcow2: add bdrv_measure() support Max Reitz
2017-03-16 3:41 ` Stefan Hajnoczi
2017-03-15 9:29 ` [Qemu-devel] [RFC v2 6/8] qemu-img: add measure subcommand Stefan Hajnoczi
2017-03-16 1:46 ` Max Reitz
2017-03-16 3:45 ` Stefan Hajnoczi
2017-03-15 9:29 ` [Qemu-devel] [RFC v2 7/8] qemu-iotests: support per-format golden output files Stefan Hajnoczi
2017-03-16 1:51 ` Max Reitz
2017-03-15 9:29 ` [Qemu-devel] [RFC v2 8/8] iotests: add test 178 for qemu-img measure Stefan Hajnoczi
2017-03-18 21:04 ` Nir Soffer
2017-03-20 15:43 ` Stefan Hajnoczi
2017-03-17 23:45 ` [Qemu-devel] [RFC v2 0/8] qemu-img: add measure sub-command Nir Soffer
2017-03-20 15:51 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170315092940.1367-6-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=berrange@redhat.com \
--cc=berto@igalia.com \
--cc=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mlipchuk@redhat.com \
--cc=nsoffer@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).