qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: dgilbert@redhat.com, Lidong Chen <jemmy858585@gmail.com>
Subject: [Qemu-devel] [PULL 3/6] migration/block: Avoid invoking blk_drain too frequently
Date: Thu, 16 Mar 2017 10:01:38 +0100	[thread overview]
Message-ID: <20170316090141.13421-4-quintela@redhat.com> (raw)
In-Reply-To: <20170316090141.13421-1-quintela@redhat.com>

From: Lidong Chen <jemmy858585@gmail.com>

Increase bmds->cur_dirty after submit io, so reduce the frequency
involve into blk_drain, and improve the performance obviously
when block migration.

The performance test result of this patch:

During the block dirty save phase, this patch improve guest os IOPS
from 4.0K to 9.5K. and improve the migration speed from
505856 rsec/s to 855756 rsec/s.

Signed-off-by: Lidong Chen <jemmy858585@gmail.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 migration/block.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/migration/block.c b/migration/block.c
index 6741228..7734ff7 100644
--- a/migration/block.c
+++ b/migration/block.c
@@ -576,6 +576,9 @@ static int mig_save_device_dirty(QEMUFile *f, BlkMigDevState *bmds,
             }
 
             bdrv_reset_dirty_bitmap(bmds->dirty_bitmap, sector, nr_sectors);
+            sector += nr_sectors;
+            bmds->cur_dirty = sector;
+
             break;
         }
         sector += BDRV_SECTORS_PER_DIRTY_CHUNK;
-- 
2.9.3

  parent reply	other threads:[~2017-03-16  9:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-16  9:01 [Qemu-devel] [PULL 0/6] Migration fixes Juan Quintela
2017-03-16  9:01 ` [Qemu-devel] [PULL 1/6] Change the method to calculate dirty-pages-rate Juan Quintela
2017-03-16  9:01 ` [Qemu-devel] [PULL 2/6] migration: use "" as the default for tls-creds/hostname Juan Quintela
2017-03-16  9:01 ` Juan Quintela [this message]
2017-03-16  9:01 ` [Qemu-devel] [PULL 4/6] vmstate: fix failed iotests case 68 and 91 Juan Quintela
2017-03-16  9:01 ` [Qemu-devel] [PULL 5/6] RAMBlocks: qemu_ram_is_shared Juan Quintela
2017-03-16  9:01 ` [Qemu-devel] [PULL 6/6] postcopy: Check for shared memory Juan Quintela
2017-03-16 16:39 ` [Qemu-devel] [PULL 0/6] Migration fixes Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170316090141.13421-4-quintela@redhat.com \
    --to=quintela@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=jemmy858585@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).