From: Anthony PERARD <anthony.perard@citrix.com>
To: Igor Druzhinin <igor.druzhinin@citrix.com>
Cc: sstabellini@kernel.org, crosthwaite.peter@gmail.com,
qemu-devel@nongnu.org, paul.durrant@citrix.com,
pbonzini@redhat.com, xen-devel@lists.xenproject.org,
rth@twiddle.net
Subject: Re: [Qemu-devel] [Xen-devel] [PATCH v5] xen: don't save/restore the physmap on VM save/restore
Date: Thu, 16 Mar 2017 14:46:56 +0000 [thread overview]
Message-ID: <20170316144656.GD1882@perard.uk.xensource.com> (raw)
In-Reply-To: <383dc5c1-f8f6-d4f2-d548-96ff2712140b@citrix.com>
On Thu, Mar 16, 2017 at 02:06:21PM +0000, Igor Druzhinin wrote:
> On 16/03/17 12:54, Igor Druzhinin wrote:
> > On 16/03/17 12:26, Anthony PERARD wrote:
> >> I've tried to migrate a guest with this patch, but once migrated, the
> >> screen is black (via VNC, keyboard is working fine).
> >>
> > Hmm. It works for me - I've tried to migrate between identical QEMUs
> > with this patch on localhost. Save/restore also works fine.
> >
> Ok. I could track down the issue - starting from v4 the patch doesn't
> work for cirrus. The reason is that post_load handler is different for
> cirrus and doesn't call the parent handler from common vga code.
>
> I manage to fix it by updating the corresponding handler by duplicating
> the code. But is it a good solution? Would it be better to have the
> common handler called in this function instead?
:(, vga_common_post_load have a misleading name. Yes, I think it would
be better to have a common post_load been called by every vga cards.
--
Anthony PERARD
next prev parent reply other threads:[~2017-03-16 14:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-15 16:01 [Qemu-devel] [PATCH v5] xen: don't save/restore the physmap on VM save/restore Igor Druzhinin
2017-03-16 12:26 ` Anthony PERARD
2017-03-16 12:54 ` Igor Druzhinin
2017-03-16 14:06 ` [Qemu-devel] [Xen-devel] " Igor Druzhinin
2017-03-16 14:46 ` Anthony PERARD [this message]
2017-03-16 15:03 ` Anthony PERARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170316144656.GD1882@perard.uk.xensource.com \
--to=anthony.perard@citrix.com \
--cc=crosthwaite.peter@gmail.com \
--cc=igor.druzhinin@citrix.com \
--cc=paul.durrant@citrix.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).