From: Fam Zheng <famz@redhat.com>
To: Ed Swierk <eswierk@skyportsystems.com>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 2/2] virtio-scsi: Fix acquire/release in dataplane handlers
Date: Fri, 17 Mar 2017 09:34:52 +0800 [thread overview]
Message-ID: <20170317013452.GA13125@lemon.lan> (raw)
In-Reply-To: <CAO_EM_k2FRArLndbSQnzbqkkmB6wRvcHCHsWbf1QRn=G=WHvZA@mail.gmail.com>
On Thu, 03/16 16:48, Ed Swierk wrote:
> On Tue, Mar 14, 2017 at 8:36 AM, Fam Zheng <famz@redhat.com> wrote:
> > diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c
> > index e7466d3..4939f1f 100644
> > --- a/hw/scsi/virtio-scsi.c
> > +++ b/hw/scsi/virtio-scsi.c
> > ...
> > bool virtio_scsi_handle_event_vq(VirtIOSCSI *s, VirtQueue *vq)
> > {
> > - virtio_scsi_acquire(s);
> > if (s->events_dropped) {
> > virtio_scsi_push_event(s, NULL, VIRTIO_SCSI_T_NO_EVENT, 0);
> > virtio_scsi_release(s);
>
> Did you intend to leave this virtio_scsi_release() call?
Oops, no, we should drop it.
Fam
>
> > return true;
> > }
> > - virtio_scsi_release(s);
> > return false;
> > }
next prev parent reply other threads:[~2017-03-17 1:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-14 15:36 [Qemu-devel] [PATCH v2 0/2] virtio-scsi: Fix assertion failure on dataplane handlers Fam Zheng
2017-03-14 15:36 ` [Qemu-devel] [PATCH v2 1/2] virtio-scsi: Make virtio_scsi_acquire/release public Fam Zheng
2017-03-14 15:36 ` [Qemu-devel] [PATCH v2 2/2] virtio-scsi: Fix acquire/release in dataplane handlers Fam Zheng
2017-03-15 17:25 ` Ed Swierk
2017-03-16 1:22 ` Fam Zheng
2017-03-16 23:48 ` Ed Swierk
2017-03-17 1:34 ` Fam Zheng [this message]
2017-03-17 0:26 ` Ed Swierk
2017-03-17 6:02 ` Fam Zheng
2017-03-17 6:13 ` Ed Swierk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170317013452.GA13125@lemon.lan \
--to=famz@redhat.com \
--cc=eswierk@skyportsystems.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).