* [Qemu-devel] [PATCH] vnc: fix a qio-channel leak
@ 2017-03-17 9:28 Marc-André Lureau
2017-03-17 10:14 ` Daniel P. Berrange
0 siblings, 1 reply; 3+ messages in thread
From: Marc-André Lureau @ 2017-03-17 9:28 UTC (permalink / raw)
To: qemu-devel; +Cc: kraxel, berrange, Marc-André Lureau
Spotted by ASAN.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
ui/vnc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/ui/vnc.c b/ui/vnc.c
index 8bfb1e0685..6e93b883b5 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -3677,6 +3677,7 @@ static int vnc_display_listen_addr(VncDisplay *vd,
qio_channel_set_name(QIO_CHANNEL(sioc), name);
if (qio_channel_socket_listen_sync(
sioc, rawaddrs[i], listenerr == NULL ? &listenerr : NULL) < 0) {
+ object_unref(OBJECT(sioc));
continue;
}
listening = true;
--
2.12.0.191.gc5d8de91d
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] vnc: fix a qio-channel leak
2017-03-17 9:28 [Qemu-devel] [PATCH] vnc: fix a qio-channel leak Marc-André Lureau
@ 2017-03-17 10:14 ` Daniel P. Berrange
2017-03-17 14:22 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 3+ messages in thread
From: Daniel P. Berrange @ 2017-03-17 10:14 UTC (permalink / raw)
To: Marc-André Lureau; +Cc: qemu-devel, kraxel
On Fri, Mar 17, 2017 at 01:28:02PM +0400, Marc-André Lureau wrote:
> Spotted by ASAN.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> ui/vnc.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
> diff --git a/ui/vnc.c b/ui/vnc.c
> index 8bfb1e0685..6e93b883b5 100644
> --- a/ui/vnc.c
> +++ b/ui/vnc.c
> @@ -3677,6 +3677,7 @@ static int vnc_display_listen_addr(VncDisplay *vd,
> qio_channel_set_name(QIO_CHANNEL(sioc), name);
> if (qio_channel_socket_listen_sync(
> sioc, rawaddrs[i], listenerr == NULL ? &listenerr : NULL) < 0) {
> + object_unref(OBJECT(sioc));
> continue;
> }
> listening = true;
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] vnc: fix a qio-channel leak
2017-03-17 10:14 ` Daniel P. Berrange
@ 2017-03-17 14:22 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2017-03-17 14:22 UTC (permalink / raw)
To: Daniel P. Berrange, Marc-André Lureau; +Cc: qemu-devel, kraxel
On 03/17/2017 07:14 AM, Daniel P. Berrange wrote:
> On Fri, Mar 17, 2017 at 01:28:02PM +0400, Marc-André Lureau wrote:
>> Spotted by ASAN.
>>
>> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>> ---
>> ui/vnc.c | 1 +
>> 1 file changed, 1 insertion(+)
>
> Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> diff --git a/ui/vnc.c b/ui/vnc.c
>> index 8bfb1e0685..6e93b883b5 100644
>> --- a/ui/vnc.c
>> +++ b/ui/vnc.c
>> @@ -3677,6 +3677,7 @@ static int vnc_display_listen_addr(VncDisplay *vd,
>> qio_channel_set_name(QIO_CHANNEL(sioc), name);
>> if (qio_channel_socket_listen_sync(
>> sioc, rawaddrs[i], listenerr == NULL ? &listenerr : NULL) < 0) {
>> + object_unref(OBJECT(sioc));
>> continue;
>> }
>> listening = true;
>
> Regards,
> Daniel
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-17 14:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-17 9:28 [Qemu-devel] [PATCH] vnc: fix a qio-channel leak Marc-André Lureau
2017-03-17 10:14 ` Daniel P. Berrange
2017-03-17 14:22 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).