* [Qemu-devel] [PATCH] oslib-posix: fix compilation on OpenBSD
@ 2017-03-17 15:22 Paolo Bonzini
2017-03-17 18:20 ` Philippe Mathieu-Daudé
2017-03-18 17:24 ` Peter Maydell
0 siblings, 2 replies; 3+ messages in thread
From: Paolo Bonzini @ 2017-03-17 15:22 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.maydell
si_band is not found in OpenBSD. It is marked as obsolescent in
POSIX, so we can delete it without any remorse.
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
util/oslib-posix.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/util/oslib-posix.c b/util/oslib-posix.c
index 94d81b9..3fe6089 100644
--- a/util/oslib-posix.c
+++ b/util/oslib-posix.c
@@ -709,8 +709,6 @@ void sigaction_invoke(struct sigaction *action,
si.si_pid = info->ssi_pid;
si.si_status = info->ssi_status;
si.si_uid = info->ssi_uid;
- } else if (info->ssi_signo == SIGIO) {
- si.si_band = info->ssi_band;
}
action->sa_sigaction(info->ssi_signo, &si, NULL);
}
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] oslib-posix: fix compilation on OpenBSD
2017-03-17 15:22 [Qemu-devel] [PATCH] oslib-posix: fix compilation on OpenBSD Paolo Bonzini
@ 2017-03-17 18:20 ` Philippe Mathieu-Daudé
2017-03-18 17:24 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2017-03-17 18:20 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: peter.maydell
On 03/17/2017 12:22 PM, Paolo Bonzini wrote:
> si_band is not found in OpenBSD. It is marked as obsolescent in
> POSIX, so we can delete it without any remorse.
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> util/oslib-posix.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/util/oslib-posix.c b/util/oslib-posix.c
> index 94d81b9..3fe6089 100644
> --- a/util/oslib-posix.c
> +++ b/util/oslib-posix.c
> @@ -709,8 +709,6 @@ void sigaction_invoke(struct sigaction *action,
> si.si_pid = info->ssi_pid;
> si.si_status = info->ssi_status;
> si.si_uid = info->ssi_uid;
> - } else if (info->ssi_signo == SIGIO) {
> - si.si_band = info->ssi_band;
> }
> action->sa_sigaction(info->ssi_signo, &si, NULL);
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] oslib-posix: fix compilation on OpenBSD
2017-03-17 15:22 [Qemu-devel] [PATCH] oslib-posix: fix compilation on OpenBSD Paolo Bonzini
2017-03-17 18:20 ` Philippe Mathieu-Daudé
@ 2017-03-18 17:24 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2017-03-18 17:24 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: QEMU Developers
On 17 March 2017 at 15:22, Paolo Bonzini <pbonzini@redhat.com> wrote:
> si_band is not found in OpenBSD. It is marked as obsolescent in
> POSIX, so we can delete it without any remorse.
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> util/oslib-posix.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/util/oslib-posix.c b/util/oslib-posix.c
> index 94d81b9..3fe6089 100644
> --- a/util/oslib-posix.c
> +++ b/util/oslib-posix.c
> @@ -709,8 +709,6 @@ void sigaction_invoke(struct sigaction *action,
> si.si_pid = info->ssi_pid;
> si.si_status = info->ssi_status;
> si.si_uid = info->ssi_uid;
> - } else if (info->ssi_signo == SIGIO) {
> - si.si_band = info->ssi_band;
> }
> action->sa_sigaction(info->ssi_signo, &si, NULL);
> }
> --
> 2.9.3
Applied to master as a buildfix, thanks.
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-18 17:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-17 15:22 [Qemu-devel] [PATCH] oslib-posix: fix compilation on OpenBSD Paolo Bonzini
2017-03-17 18:20 ` Philippe Mathieu-Daudé
2017-03-18 17:24 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).