Re: [Qemu-devel] [PATCH 1/1] parallels: fix default options parsing

[Stefan Hajnoczi <stefanha@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1145 bytes --]

On Mon, Mar 20, 2017 at 12:27:02PM +0300, Denis V. Lunev wrote:
> From: Edgar Kaziahmedov <edos@virtuozzo.mipt.ru>
> 
> parallels block driver is completely broken since commit
>     commit 75cdcd1553e74b5edc58aed23e3b2da8dabb1876
>     Author: Markus Armbruster <armbru@redhat.com>
>     Date:   Tue Feb 21 21:14:08 2017 +0100
>     option: Fix checking of sizes for overflow and trailing crap
> Right now even simple
>     qemu-io -c "read 512 64k" 1.hds
> ends up with
>     Unexpected error in parse_option_size() at util/qemu-option.c:188:
>     Parameter 'prealloc-size' expects a non-negative number below 2^64
>     Aborted (core dumped)
> The cure is simple - we should use 'M' as a suffix in default option value
> instead of 'MiB'.
> 
> Signed-off-by: Edgar Kaziahmedov <edos@virtuozzo.mipt.ru>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Markus Armbruster <armbru@redhat.com>
> CC: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  block/parallels.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]