From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>,
qemu-block@nongnu.org
Subject: [Qemu-devel] [PATCH RFC 02/16] block-backend: Add blk_request_perm
Date: Tue, 21 Mar 2017 11:16:21 +0800 [thread overview]
Message-ID: <20170321031635.22123-3-famz@redhat.com> (raw)
In-Reply-To: <20170321031635.22123-1-famz@redhat.com>
This function tries to request, if not granted yet, for the given
permissions.
Signed-off-by: Fam Zheng <famz@redhat.com>
---
block/block-backend.c | 12 ++++++++++++
include/sysemu/block-backend.h | 1 +
2 files changed, 13 insertions(+)
diff --git a/block/block-backend.c b/block/block-backend.c
index 5742c09..5d17404 100644
--- a/block/block-backend.c
+++ b/block/block-backend.c
@@ -595,6 +595,18 @@ void blk_get_perm(BlockBackend *blk, uint64_t *perm, uint64_t *shared_perm)
*shared_perm = blk->shared_perm;
}
+int blk_request_perm(BlockBackend *blk, uint64_t perm, Error **errp)
+{
+ uint64_t blk_perm, shared_perm;
+
+ blk_get_perm(blk, &blk_perm, &shared_perm);
+ if ((blk_perm & perm) == perm) {
+ return 0;
+ }
+ blk_perm |= perm;
+ return blk_set_perm(blk, blk_perm, shared_perm, errp);
+}
+
static int blk_do_attach_dev(BlockBackend *blk, void *dev)
{
if (blk->dev) {
diff --git a/include/sysemu/block-backend.h b/include/sysemu/block-backend.h
index 096c17f..016632e 100644
--- a/include/sysemu/block-backend.h
+++ b/include/sysemu/block-backend.h
@@ -108,6 +108,7 @@ bool bdrv_is_root_node(BlockDriverState *bs);
int blk_set_perm(BlockBackend *blk, uint64_t perm, uint64_t shared_perm,
Error **errp);
void blk_get_perm(BlockBackend *blk, uint64_t *perm, uint64_t *shared_perm);
+int blk_request_perm(BlockBackend *blk, uint64_t perm, Error **errp);
void blk_set_allow_write_beyond_eof(BlockBackend *blk, bool allow);
void blk_iostatus_enable(BlockBackend *blk);
--
2.9.3
next prev parent reply other threads:[~2017-03-21 3:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-21 3:16 [Qemu-devel] [PATCH RFC 00/16] block: Protect AIO context change with perm API Fam Zheng
2017-03-21 3:16 ` [Qemu-devel] [PATCH RFC 01/16] block: Define BLK_PERM_AIO_CONTEXT_CHANGE Fam Zheng
2017-03-21 3:16 ` Fam Zheng [this message]
2017-03-21 3:16 ` [Qemu-devel] [PATCH RFC 03/16] blockjob: Add BLK_PERM_AIO_CONTEXT_CHANGE shared perm on bs Fam Zheng
2017-03-21 3:16 ` [Qemu-devel] [PATCH RFC 04/16] block: Propagate BLK_PERM_AIO_CONTEXT_CHANGE down the graph Fam Zheng
2017-04-10 8:57 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-04-18 9:24 ` Fam Zheng
2017-03-21 3:16 ` [Qemu-devel] [PATCH RFC 05/16] backup: Request BLK_PERM_AIO_CONTEXT_CHANGE on target Fam Zheng
2017-03-21 3:16 ` [Qemu-devel] [PATCH RFC 06/16] backup: Do initial aio context move of target via BB interface Fam Zheng
2017-03-21 3:16 ` [Qemu-devel] [PATCH RFC 07/16] mirror: Request aio context change permission on target Fam Zheng
2017-03-21 3:16 ` [Qemu-devel] [PATCH RFC 08/16] commit: Allow aio context change on s->base Fam Zheng
2017-03-21 3:16 ` [Qemu-devel] [PATCH RFC 09/16] mirror: Do initial aio context move of target via BB interface Fam Zheng
2017-03-21 3:16 ` [Qemu-devel] [PATCH RFC 10/16] virtio-scsi: Request BLK_PERM_AIO_CONTEXT_CHANGE for dataplane Fam Zheng
2017-03-21 3:16 ` [Qemu-devel] [PATCH RFC 11/16] virtio-blk: " Fam Zheng
2017-03-21 3:16 ` [Qemu-devel] [PATCH RFC 12/16] blk: fix aio context loss on media change Fam Zheng
2017-03-21 3:16 ` [Qemu-devel] [PATCH RFC 13/16] nbd: Allow BLK_PERM_AIO_CONTEXT_CHANGE on BB Fam Zheng
2017-03-21 3:16 ` [Qemu-devel] [PATCH RFC 14/16] block: Add perm assertion on blk_set_aio_context Fam Zheng
2017-03-21 3:16 ` [Qemu-devel] [PATCH RFC 15/16] mirror: Lazily request aio context change permission on target Fam Zheng
2017-03-21 3:16 ` [Qemu-devel] [PATCH RFC 16/16] Revert "mirror: Request aio context change permission on target" Fam Zheng
2017-04-10 9:04 ` [Qemu-devel] [Qemu-block] [PATCH RFC 00/16] block: Protect AIO context change with perm API Stefan Hajnoczi
2017-04-10 10:58 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170321031635.22123-3-famz@redhat.com \
--to=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).