* [Qemu-devel] [PATCH qemu-ga] Start VSS Provider after install
@ 2017-03-21 12:03 Sameeh Jubran
2017-03-21 16:15 ` Michael Roth
0 siblings, 1 reply; 3+ messages in thread
From: Sameeh Jubran @ 2017-03-21 12:03 UTC (permalink / raw)
To: qemu-devel, Michael Roth; +Cc: Yan Vugenfirer
Signed-off-by: Sameeh Jubran <sameeh@daynix.com>
---
qga/vss-win32/install.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/qga/vss-win32/install.cpp b/qga/vss-win32/install.cpp
index f4160a3..7e38332 100644
--- a/qga/vss-win32/install.cpp
+++ b/qga/vss-win32/install.cpp
@@ -307,6 +307,7 @@ STDAPI COMRegister(void)
chk(put_Value(pObj, L"User", L"SYSTEM"));
chk(pUsersInRole->SaveChanges(&n));
+ chk(pCatalog->StartApplication(_bstr_t(QGA_PROVIDER_LNAME)));
out:
if (unregisterOnFailure && FAILED(hr)) {
COMUnregister();
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH qemu-ga] Start VSS Provider after install
2017-03-21 12:03 [Qemu-devel] [PATCH qemu-ga] Start VSS Provider after install Sameeh Jubran
@ 2017-03-21 16:15 ` Michael Roth
2017-03-22 10:58 ` Sameeh Jubran
0 siblings, 1 reply; 3+ messages in thread
From: Michael Roth @ 2017-03-21 16:15 UTC (permalink / raw)
To: Sameeh Jubran, qemu-devel; +Cc: Yan Vugenfirer
Quoting Sameeh Jubran (2017-03-21 07:03:26)
> Signed-off-by: Sameeh Jubran <sameeh@daynix.com>
What happens without this patch? Fresh installs don't report the
fsfreeze interface as available?
> ---
> qga/vss-win32/install.cpp | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/qga/vss-win32/install.cpp b/qga/vss-win32/install.cpp
> index f4160a3..7e38332 100644
> --- a/qga/vss-win32/install.cpp
> +++ b/qga/vss-win32/install.cpp
> @@ -307,6 +307,7 @@ STDAPI COMRegister(void)
> chk(put_Value(pObj, L"User", L"SYSTEM"));
> chk(pUsersInRole->SaveChanges(&n));
>
> + chk(pCatalog->StartApplication(_bstr_t(QGA_PROVIDER_LNAME)));
> out:
> if (unregisterOnFailure && FAILED(hr)) {
> COMUnregister();
> --
> 2.9.3
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH qemu-ga] Start VSS Provider after install
2017-03-21 16:15 ` Michael Roth
@ 2017-03-22 10:58 ` Sameeh Jubran
0 siblings, 0 replies; 3+ messages in thread
From: Sameeh Jubran @ 2017-03-22 10:58 UTC (permalink / raw)
To: Michael Roth; +Cc: qemu-devel, Yan Vugenfirer
On Tue, Mar 21, 2017 at 6:15 PM, Michael Roth <mdroth@linux.vnet.ibm.com>
wrote:
> Quoting Sameeh Jubran (2017-03-21 07:03:26)
> > Signed-off-by: Sameeh Jubran <sameeh@daynix.com>
>
> What happens without this patch? Fresh installs don't report the
> fsfreeze interface as available?
>
It solves a bug (https://bugzilla.redhat.com/show_bug.cgi?id=1218937) that
was reported in bugzilla, however
thinking about it again this patch is not needed as the service should
only be running when it is needed.
>
> > ---
> > qga/vss-win32/install.cpp | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/qga/vss-win32/install.cpp b/qga/vss-win32/install.cpp
> > index f4160a3..7e38332 100644
> > --- a/qga/vss-win32/install.cpp
> > +++ b/qga/vss-win32/install.cpp
> > @@ -307,6 +307,7 @@ STDAPI COMRegister(void)
> > chk(put_Value(pObj, L"User", L"SYSTEM"));
> > chk(pUsersInRole->SaveChanges(&n));
> >
> > + chk(pCatalog->StartApplication(_bstr_t(QGA_PROVIDER_LNAME)));
> > out:
> > if (unregisterOnFailure && FAILED(hr)) {
> > COMUnregister();
> > --
> > 2.9.3
> >
>
>
--
Respectfully,
*Sameeh Jubran*
*Linkedin <https://il.linkedin.com/pub/sameeh-jubran/87/747/a8a>*
*Software Engineer @ Daynix <http://www.daynix.com>.*
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-22 10:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-21 12:03 [Qemu-devel] [PATCH qemu-ga] Start VSS Provider after install Sameeh Jubran
2017-03-21 16:15 ` Michael Roth
2017-03-22 10:58 ` Sameeh Jubran
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).