From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, kraxel@redhat.com, quintela@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/2 for 2.10] Remove some monitor_printf's
Date: Tue, 21 Mar 2017 12:22:11 +0000 [thread overview]
Message-ID: <20170321122211.GD3248@work-vm> (raw)
In-Reply-To: <87bmsuomgf.fsf@dusky.pond.sub.org>
* Markus Armbruster (armbru@redhat.com) wrote:
> "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> writes:
>
> > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> >
> > I found myself trying to understand cur_mon and found a bunch
> > of uses that could easily be replaced by error_report or Error **.
>
> Speaking of cur_mon: a patch making it thread-local would be most
> welcome.
Yep, that's what I was thinking about while I was just working out where
it's used.
> Some of error wavcapture messages still aren't so great, but it's an
> obvious improvement, so
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
Thanks.
Dave
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
prev parent reply other threads:[~2017-03-21 12:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 17:38 [Qemu-devel] [PATCH 0/2 for 2.10] Remove some monitor_printf's Dr. David Alan Gilbert (git)
2017-03-20 17:38 ` [Qemu-devel] [PATCH 1/2] save_vmstate: Convert to Error** from Monitor * Dr. David Alan Gilbert (git)
2017-03-20 18:05 ` Juan Quintela
2017-03-20 17:38 ` [Qemu-devel] [PATCH 2/2] wavcapture: Convert to error_report Dr. David Alan Gilbert (git)
2017-03-21 6:38 ` Gerd Hoffmann
2017-06-13 11:26 ` Dr. David Alan Gilbert
2017-03-21 12:15 ` [Qemu-devel] [PATCH 0/2 for 2.10] Remove some monitor_printf's Markus Armbruster
2017-03-21 12:22 ` Dr. David Alan Gilbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170321122211.GD3248@work-vm \
--to=dgilbert@redhat.com \
--cc=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).