From: Sameeh Jubran <sameeh@daynix.com>
To: qemu-devel@nongnu.org, Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: Yan Vugenfirer <yan@daynix.com>
Subject: [Qemu-devel] [PATCH qemu-ga] qemu-ga: Don't display errors to the user on thaw command
Date: Tue, 21 Mar 2017 16:14:35 +0200 [thread overview]
Message-ID: <20170321141435.23701-1-sameeh@daynix.com> (raw)
Errors that are related to ur inner implementation for the thaw command
shouldn't be displayed to the user.
Signed-off-by: Sameeh Jubran <sameeh@daynix.com>
---
qga/vss-win32/requester.cpp | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/qga/vss-win32/requester.cpp b/qga/vss-win32/requester.cpp
index 0cd2f0e..272e71b 100644
--- a/qga/vss-win32/requester.cpp
+++ b/qga/vss-win32/requester.cpp
@@ -463,7 +463,7 @@ void requester_thaw(int *num_vols, ErrorSet *errset)
hr = WaitForAsync(pAsync);
}
if (FAILED(hr)) {
- err_set(errset, hr, "failed to complete backup");
+ fprintf(stderr, "failed to complete backup");
}
break;
@@ -480,18 +480,18 @@ void requester_thaw(int *num_vols, ErrorSet *errset)
case VSS_E_UNEXPECTED_PROVIDER_ERROR:
if (WaitForSingleObject(vss_ctx.hEventTimeout, 0) != WAIT_OBJECT_0) {
- err_set(errset, hr, "unexpected error in VSS provider");
+ fprintf(stderr, "unexpected error in VSS provider");
break;
}
/* fall through if hEventTimeout is signaled */
case (HRESULT)VSS_E_HOLD_WRITES_TIMEOUT:
- err_set(errset, hr, "couldn't hold writes: "
+ fprintf(stderr, "couldn't hold writes: "
"fsfreeze is limited up to 10 seconds");
break;
default:
- err_set(errset, hr, "failed to do snapshot set");
+ fprintf(stderr, "failed to do snapshot set");
}
if (err_is_set(errset)) {
--
2.9.3
next reply other threads:[~2017-03-21 14:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-21 14:14 Sameeh Jubran [this message]
2017-04-02 7:33 ` [Qemu-devel] [PATCH qemu-ga] qemu-ga: Don't display errors to the user on thaw command Sameeh Jubran
2017-04-04 22:55 ` Michael Roth
2017-04-05 14:34 ` Sameeh Jubran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170321141435.23701-1-sameeh@daynix.com \
--to=sameeh@daynix.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=yan@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).