* [Qemu-devel] [PATCH] cirrus: fix PUTPIXEL macro
@ 2017-03-22 7:38 Gerd Hoffmann
2017-03-22 11:41 ` Dr. David Alan Gilbert
0 siblings, 1 reply; 2+ messages in thread
From: Gerd Hoffmann @ 2017-03-22 7:38 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann
Should be "c" not "col". The macro is used with "col" as third parameter
everywhere, so this tyops doesn't break something.
Fixes: 026aeffcb4752054830ba203020ed6eb05bcaba8
Reported-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/display/cirrus_vga_rop2.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/display/cirrus_vga_rop2.h b/hw/display/cirrus_vga_rop2.h
index b86bcd6..b208b73 100644
--- a/hw/display/cirrus_vga_rop2.h
+++ b/hw/display/cirrus_vga_rop2.h
@@ -29,8 +29,8 @@
#elif DEPTH == 24
#define PUTPIXEL(s, a, c) do { \
ROP_OP(s, a, c); \
- ROP_OP(s, a + 1, (col >> 8)); \
- ROP_OP(s, a + 2, (col >> 16)); \
+ ROP_OP(s, a + 1, (c >> 8)); \
+ ROP_OP(s, a + 2, (c >> 16)); \
} while (0)
#elif DEPTH == 32
#define PUTPIXEL(s, a, c) ROP_OP_32(s, a, c)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] cirrus: fix PUTPIXEL macro
2017-03-22 7:38 [Qemu-devel] [PATCH] cirrus: fix PUTPIXEL macro Gerd Hoffmann
@ 2017-03-22 11:41 ` Dr. David Alan Gilbert
0 siblings, 0 replies; 2+ messages in thread
From: Dr. David Alan Gilbert @ 2017-03-22 11:41 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: qemu-devel
* Gerd Hoffmann (kraxel@redhat.com) wrote:
> Should be "c" not "col". The macro is used with "col" as third parameter
> everywhere, so this tyops doesn't break something.
>
> Fixes: 026aeffcb4752054830ba203020ed6eb05bcaba8
> Reported-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> hw/display/cirrus_vga_rop2.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/display/cirrus_vga_rop2.h b/hw/display/cirrus_vga_rop2.h
> index b86bcd6..b208b73 100644
> --- a/hw/display/cirrus_vga_rop2.h
> +++ b/hw/display/cirrus_vga_rop2.h
> @@ -29,8 +29,8 @@
> #elif DEPTH == 24
> #define PUTPIXEL(s, a, c) do { \
> ROP_OP(s, a, c); \
> - ROP_OP(s, a + 1, (col >> 8)); \
> - ROP_OP(s, a + 2, (col >> 16)); \
> + ROP_OP(s, a + 1, (c >> 8)); \
> + ROP_OP(s, a + 2, (c >> 16)); \
> } while (0)
> #elif DEPTH == 32
> #define PUTPIXEL(s, a, c) ROP_OP_32(s, a, c)
> --
> 1.8.3.1
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-22 11:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-22 7:38 [Qemu-devel] [PATCH] cirrus: fix PUTPIXEL macro Gerd Hoffmann
2017-03-22 11:41 ` Dr. David Alan Gilbert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).