From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39636) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cqirl-0003VC-1d for qemu-devel@nongnu.org; Wed, 22 Mar 2017 12:12:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cqirj-0005tz-Vz for qemu-devel@nongnu.org; Wed, 22 Mar 2017 12:12:05 -0400 Date: Wed, 22 Mar 2017 12:11:56 -0400 From: Jeff Cody Message-ID: <20170322161156.GJ3411@localhost.localdomain> References: <20170316212351.13797-1-jsnow@redhat.com> <20170316212351.13797-4-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170316212351.13797-4-jsnow@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 3/3] blockjob: add devops to blockjob backends List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: qemu-block@nongnu.org, kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org On Thu, Mar 16, 2017 at 05:23:51PM -0400, John Snow wrote: > This lets us hook into drained_begin and drained_end requests from the > backend level, which is particularly useful for making sure that all > jobs associated with a particular node (whether the source or the target) > receive a drain request. > > Suggested-by: Kevin Wolf > Signed-off-by: John Snow > --- > blockjob.c | 29 ++++++++++++++++++++++++----- > 1 file changed, 24 insertions(+), 5 deletions(-) > > diff --git a/blockjob.c b/blockjob.c > index 69b4ec6..a11d5ce 100644 > --- a/blockjob.c > +++ b/blockjob.c > @@ -68,6 +68,23 @@ static const BdrvChildRole child_job = { > .stay_at_node = true, > }; > > +static void block_job_drained_begin(void *opaque) > +{ > + BlockJob *job = opaque; > + block_job_pause(job); > +} > + > +static void block_job_drained_end(void *opaque) > +{ > + BlockJob *job = opaque; > + block_job_resume(job); > +} > + > +static const BlockDevOps block_job_dev_ops = { > + .drained_begin = block_job_drained_begin, > + .drained_end = block_job_drained_end, > +}; > + > BlockJob *block_job_next(BlockJob *job) > { > if (!job) { > @@ -205,11 +222,6 @@ void *block_job_create(const char *job_id, const BlockJobDriver *driver, > } > > job = g_malloc0(driver->instance_size); > - error_setg(&job->blocker, "block device is in use by block job: %s", > - BlockJobType_lookup[driver->job_type]); > - block_job_add_bdrv(job, "main node", bs, 0, BLK_PERM_ALL, &error_abort); > - bdrv_op_unblock(bs, BLOCK_OP_TYPE_DATAPLANE, job->blocker); > - > job->driver = driver; > job->id = g_strdup(job_id); > job->blk = blk; > @@ -219,8 +231,15 @@ void *block_job_create(const char *job_id, const BlockJobDriver *driver, > job->paused = true; > job->pause_count = 1; > job->refcnt = 1; > + > + error_setg(&job->blocker, "block device is in use by block job: %s", > + BlockJobType_lookup[driver->job_type]); > + block_job_add_bdrv(job, "main node", bs, 0, BLK_PERM_ALL, &error_abort); > bs->job = job; > > + blk_set_dev_ops(blk, &block_job_dev_ops, job); > + bdrv_op_unblock(bs, BLOCK_OP_TYPE_DATAPLANE, job->blocker); > + > QLIST_INSERT_HEAD(&block_jobs, job, job_list); > > blk_add_aio_context_notifier(blk, block_job_attached_aio_context, > -- > 2.9.3 > Reviewed-by: Jeff Cody