From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48357) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cqjAR-0003Wj-PG for qemu-devel@nongnu.org; Wed, 22 Mar 2017 12:31:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cqjAN-0006S0-ML for qemu-devel@nongnu.org; Wed, 22 Mar 2017 12:31:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34824) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cqjAN-0006Rm-Gv for qemu-devel@nongnu.org; Wed, 22 Mar 2017 12:31:19 -0400 Date: Wed, 22 Mar 2017 18:31:17 +0200 From: "Michael S. Tsirkin" Message-ID: <20170322183050-mutt-send-email-mst@kernel.org> References: <1490198476-12244-1-git-send-email-mst@redhat.com> <1490198476-12244-5-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PULL 4/4] hw/acpi/vmgenid: prevent more than one vmgenid device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: qemu-devel@nongnu.org, Peter Maydell , Ben Warren , Igor Mammedov , Paolo Bonzini On Wed, Mar 22, 2017 at 05:21:32PM +0100, Laszlo Ersek wrote: > On 03/22/17 17:01, Michael S. Tsirkin wrote: > > From: Laszlo Ersek > > > > A system with multiple VMGENID devices is undefined in the VMGENID spec by > > omission. > > > > Cc: "Michael S. Tsirkin" > > Cc: Ben Warren > > Cc: Igor Mammedov > > Cc: Paolo Bonzini > > Signed-off-by: Laszlo Ersek > > Reviewed-by: Michael S. Tsirkin > > Signed-off-by: Michael S. Tsirkin > > Can you please add the feedback tags from Igor and Ben? > > http://mid.mail-archive.com/23205322-903E-42E2-99D7-ED8351E62694@skyportsystems.com > http://mid.mail-archive.com/20170321131414.08cc6bfa@nial.brq.redhat.com > > > Binary file /tmp/tmp.IaAwzHwwsQ matches > > I'm not sure what this means. > > Thanks, > Laszlo Fixed, thanks for paying attention. > > --- > > include/hw/acpi/vmgenid.h | 1 + > > hw/acpi/vmgenid.c | 8 ++++++++ > > 2 files changed, 9 insertions(+) > > > > diff --git a/include/hw/acpi/vmgenid.h b/include/hw/acpi/vmgenid.h > > index 8578476..7beb959 100644 > > --- a/include/hw/acpi/vmgenid.h > > +++ b/include/hw/acpi/vmgenid.h > > @@ -24,6 +24,7 @@ typedef struct VmGenIdState { > > bool write_pointer_available; > > } VmGenIdState; > > > > +/* returns NULL unless there is exactly one device */ > > static inline Object *find_vmgenid_dev(void) > > { > > return object_resolve_path_type("", VMGENID_DEVICE, NULL); > > diff --git a/hw/acpi/vmgenid.c b/hw/acpi/vmgenid.c > > index c3ddcc8..a32b847 100644 > > --- a/hw/acpi/vmgenid.c > > +++ b/hw/acpi/vmgenid.c > > @@ -221,6 +221,14 @@ static void vmgenid_realize(DeviceState *dev, Error **errp) > > return; > > } > > > > + /* Given that this function is executing, there is at least one VMGENID > > + * device. Check if there are several. > > + */ > > + if (!find_vmgenid_dev()) { > > + error_setg(errp, "at most one %s device is permitted", VMGENID_DEVICE); > > + return; > > + } > > + > > qemu_register_reset(vmgenid_handle_reset, vms); > > } > > > >