From: Peter Xu <peterx@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, dgilbert@redhat.com,
Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
Subject: Re: [Qemu-devel] [PATCH] Revert "apic: save apic_delivered flag"
Date: Thu, 23 Mar 2017 15:26:04 +0800 [thread overview]
Message-ID: <20170323072436.GE4224@pxdev.xzpeter.org> (raw)
In-Reply-To: <20170322121344.5484-1-pbonzini@redhat.com>
On Wed, Mar 22, 2017 at 01:13:44PM +0100, Paolo Bonzini wrote:
> This reverts commit 07bfa354772f2de67008dc66c201b627acff0106.
> The global variable is only read as part of a
>
> apic_reset_irq_delivered();
> qemu_irq_raise(s->irq);
> if (!apic_get_irq_delivered()) {
>
> sequence, so the value never matters at migration time.
>
> Reported-by: Dr. David Alan Gilbert <dglibert@redhat.com>
> Cc: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
-- peterx
next prev parent reply other threads:[~2017-03-23 7:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 12:13 [Qemu-devel] [PATCH] Revert "apic: save apic_delivered flag" Paolo Bonzini
2017-03-23 7:26 ` Peter Xu [this message]
2017-03-23 7:34 ` Pavel Dovgalyuk
2017-03-23 11:45 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170323072436.GE4224@pxdev.xzpeter.org \
--to=peterx@redhat.com \
--cc=dgilbert@redhat.com \
--cc=pavel.dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).