From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56736) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1csPUT-0005p9-6W for qemu-devel@nongnu.org; Mon, 27 Mar 2017 03:55:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1csPUP-0004nI-BW for qemu-devel@nongnu.org; Mon, 27 Mar 2017 03:55:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36582) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1csPUP-0004nE-5v for qemu-devel@nongnu.org; Mon, 27 Mar 2017 03:54:57 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DC4913F725 for ; Mon, 27 Mar 2017 07:54:55 +0000 (UTC) Date: Mon, 27 Mar 2017 15:54:50 +0800 From: Peter Xu Message-ID: <20170327075450.GD11497@pxdev.xzpeter.org> References: <20170323204544.12015-1-quintela@redhat.com> <20170323204544.12015-7-quintela@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170323204544.12015-7-quintela@redhat.com> Subject: Re: [Qemu-devel] [PATCH 06/51] ram: Move start time into RAMState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org, dgilbert@redhat.com On Thu, Mar 23, 2017 at 09:44:59PM +0100, Juan Quintela wrote: > Signed-off-by: Juan Quintela > Reviewed-by: Dr. David Alan Gilbert > --- > migration/ram.c | 20 +++++++++++--------- > 1 file changed, 11 insertions(+), 9 deletions(-) > > diff --git a/migration/ram.c b/migration/ram.c > index f811e81..5881805 100644 > --- a/migration/ram.c > +++ b/migration/ram.c > @@ -154,6 +154,9 @@ struct RAMState { > int dirty_rate_high_cnt; > /* How many times we have synchronized the bitmap */ > uint64_t bitmap_sync_count; > + /* this variables are used for bitmap sync */ s/this/These/? > + /* last time we did a full bitmap_sync */ > + int64_t start_time; Not sure whether it'll be a good chance we rename this variable in this patch to make it a less-generic name, like: bm_sync_start? But again, this is nicpicking and totally optional. With the typo fixed, please add: Reviewed-by: Peter Xu Thanks, -- peterx